Skip to content

Commit

Permalink
Clean-up inline members of nested classes (ash/)
Browse files Browse the repository at this point in the history
Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10837185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150807 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
hans@chromium.org committed Aug 9, 2012
1 parent f8ae4bf commit 9e52129
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions ash/wm/shelf_layout_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,8 @@ void ShelfLayoutManager::OnWindowActivated(aura::Window* active,
////////////////////////////////////////////////////////////////////////////////
// ShelfLayoutManager, private:

ShelfLayoutManager::TargetBounds::TargetBounds() : opacity(0.0f) {}

gfx::Rect ShelfLayoutManager::GetMaximizedWindowBounds(
aura::Window* window) {
gfx::Rect bounds(ScreenAsh::GetDisplayBoundsInParent(window));
Expand Down
2 changes: 1 addition & 1 deletion ash/wm/shelf_layout_manager.h
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ class ASH_EXPORT ShelfLayoutManager :
FRIEND_TEST_ALL_PREFIXES(ShelfLayoutManagerTest, SetAutoHideBehavior);

struct TargetBounds {
TargetBounds() : opacity(0.0f) {}
TargetBounds();

float opacity;
gfx::Rect launcher_bounds_in_root;
Expand Down

0 comments on commit 9e52129

Please sign in to comment.