Skip to content

Commit

Permalink
Remove 10.13, 10.14 support from auth session handling
Browse files Browse the repository at this point in the history
These macOS releases are no longer supported by Chromium.

Bug: 1410851
Change-Id: I4cfdd65d59bfba700033b217b2d3337ec10e7130
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Validate-Test-Flakiness: skip
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4672397
Auto-Submit: Avi Drissman <avi@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168712}
  • Loading branch information
Avi Drissman authored and Chromium LUCI CQ committed Jul 11, 2023
1 parent 1992f45 commit 9eab4ab
Show file tree
Hide file tree
Showing 4 changed files with 218 additions and 259 deletions.
4 changes: 2 additions & 2 deletions chrome/browser/mac/auth_session_request.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class Profile;

// A class to manage the WebContents running an
// ASWebAuthenticationSessionRequest.
class API_AVAILABLE(macos(10.15)) AuthSessionRequest
class AuthSessionRequest
: public content::WebContentsObserver,
public content::WebContentsUserData<AuthSessionRequest> {
public:
Expand Down Expand Up @@ -102,6 +102,6 @@ class API_AVAILABLE(macos(10.15)) AuthSessionRequest
// If there is an authentication session in progress for the given navigation
// handle, install a throttle.
std::unique_ptr<content::NavigationThrottle> MaybeCreateAuthSessionThrottleFor(
content::NavigationHandle* handle) API_AVAILABLE(macos(10.15));
content::NavigationHandle* handle);

#endif // CHROME_BROWSER_MAC_AUTH_SESSION_REQUEST_H_
2 changes: 1 addition & 1 deletion chrome/browser/mac/auth_session_request.mm
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ ThrottleCheckResult HandleRequest() {
WEB_CONTENTS_USER_DATA_KEY_IMPL(AuthSessionRequest);

std::unique_ptr<content::NavigationThrottle> MaybeCreateAuthSessionThrottleFor(
content::NavigationHandle* handle) API_AVAILABLE(macos(10.15)) {
content::NavigationHandle* handle) {
AuthSessionRequest* request =
AuthSessionRequest::FromWebContents(handle->GetWebContents());
if (!request)
Expand Down
Loading

0 comments on commit 9eab4ab

Please sign in to comment.