device: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add missing ones in device header files. BUG=662195 Review-Url: https://codereview.chromium.org/2542903002 Cr-Commit-Position: refs/heads/master@{#435711}
Denger-Network · Dec 1, 2016 · 9f4dfb5 · 9f4dfb5
1 parent 6650924
commit 9f4dfb5
Show file tree

Hide file tree

Showing 34 changed files with 0 additions and 84 deletions.
diff --git a/device/bluetooth/bluetooth_adapter.h b/device/bluetooth/bluetooth_adapter.h
@@ -36,7 +36,6 @@ class BluetoothRemoteGattDescriptor;
 class BluetoothRemoteGattService;
 class BluetoothSocket;
 class BluetoothUUID;
-struct BluetoothAdapterDeleter;
 enum class UMABluetoothDiscoverySessionOutcome;
 
 // BluetoothAdapter represents a local Bluetooth adapter which may be used to

diff --git a/device/bluetooth/bluetooth_adapter_win.h b/device/bluetooth/bluetooth_adapter_win.h
@@ -26,7 +26,6 @@
 
 namespace base {
 class SequencedTaskRunner;
-class Thread;
 }  // namespace base
 
 namespace device {

diff --git a/device/bluetooth/bluetooth_device.h b/device/bluetooth/bluetooth_device.h
@@ -26,10 +26,6 @@
 #include "device/bluetooth/bluetooth_export.h"
 #include "device/bluetooth/bluetooth_uuid.h"
 
-namespace base {
-class BinaryValue;
-}
-
 namespace device {
 
 class BluetoothAdapter;

diff --git a/device/bluetooth/bluetooth_gatt_characteristic.h b/device/bluetooth/bluetooth_gatt_characteristic.h
@@ -17,9 +17,6 @@
 
 namespace device {
 
-class BluetoothRemoteGattDescriptor;
-class BluetoothGattNotifySession;
-
 // BluetoothGattCharacteristic represents a local or remote GATT characteristic.
 // A GATT characteristic is a basic data element used to construct a GATT
 // service. Hence, instances of a BluetoothGattCharacteristic are associated

diff --git a/device/bluetooth/bluetooth_low_energy_device_mac.h b/device/bluetooth/bluetooth_low_energy_device_mac.h
@@ -27,7 +27,6 @@
 namespace device {
 
 class BluetoothAdapterMac;
-class BluetoothLowEnergyDiscoverManagerMac;
 class BluetoothRemoteGattServiceMac;
 
 class DEVICE_BLUETOOTH_EXPORT BluetoothLowEnergyDeviceMac

diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_win.h b/device/bluetooth/bluetooth_remote_gatt_characteristic_win.h
@@ -16,7 +16,6 @@
 
 namespace device {
 
-class BluetoothAdapterWin;
 class BluetoothRemoteGattDescriptorWin;
 class BluetoothRemoteGattServiceWin;
 class BluetoothTaskManagerWin;

diff --git a/device/bluetooth/bluetooth_remote_gatt_descriptor_win.h b/device/bluetooth/bluetooth_remote_gatt_descriptor_win.h
@@ -15,7 +15,6 @@
 
 namespace device {
 
-class BluetoothAdapterWin;
 class BluetoothRemoteGattCharacteristicWin;
 class BluetoothTaskManagerWin;
 

diff --git a/device/bluetooth/bluetooth_remote_gatt_service.h b/device/bluetooth/bluetooth_remote_gatt_service.h
@@ -16,7 +16,6 @@ namespace device {
 
 class BluetoothDevice;
 class BluetoothRemoteGattCharacteristic;
-class BluetoothRemoteGattDescriptor;
 
 // BluetoothRemoteGattService represents a remote GATT service.
 //

diff --git a/device/bluetooth/bluetooth_socket.h b/device/bluetooth/bluetooth_socket.h
@@ -18,7 +18,6 @@ class IOBuffer;
 namespace device {
 
 class BluetoothDevice;
-class BluetoothUUID;
 
 // BluetoothSocket represents a socket to a specific service on a
 // BluetoothDevice.  BluetoothSocket objects are ref counted and may outlive

diff --git a/device/bluetooth/bluez/bluetooth_gatt_descriptor_bluez.h b/device/bluetooth/bluez/bluetooth_gatt_descriptor_bluez.h
@@ -13,8 +13,6 @@
 
 namespace bluez {
 
-class BluetoothGattCharacteristicBlueZ;
-
 // The BluetoothGattDescriptorBlueZ class implements BluetoothGattDescriptor for
 // GATT characteristic descriptors for platforms that use BlueZ.
 class BluetoothGattDescriptorBlueZ

diff --git a/device/bluetooth/bluez/bluetooth_local_gatt_service_bluez.h b/device/bluetooth/bluez/bluetooth_local_gatt_service_bluez.h
@@ -16,13 +16,6 @@
 #include "device/bluetooth/bluez/bluetooth_gatt_service_bluez.h"
 #include "device/bluetooth/bluez/bluetooth_local_gatt_characteristic_bluez.h"
 
-namespace device {
-
-class BluetoothAdapter;
-class BluetoothDevice;
-
-}  // namespace device
-
 namespace bluez {
 
 class BluetoothAdapterBlueZ;

diff --git a/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h b/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h
@@ -22,7 +22,6 @@
 
 namespace device {
 
-class BluetoothAdapter;
 class BluetoothDevice;
 class BluetoothRemoteGattCharacteristic;
 

diff --git a/device/bluetooth/bluez/bluetooth_service_record_bluez.h b/device/bluetooth/bluez/bluetooth_service_record_bluez.h
@@ -13,10 +13,6 @@
 #include "device/bluetooth/bluetooth_export.h"
 #include "device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h"
 
-namespace base {
-class Value;
-}
-
 namespace bluez {
 
 class DEVICE_BLUETOOTH_EXPORT BluetoothServiceRecordBlueZ {

diff --git a/device/bluetooth/dbus/bluez_dbus_manager.h b/device/bluetooth/dbus/bluez_dbus_manager.h
@@ -17,7 +17,6 @@
 
 namespace dbus {
 class Bus;
-class ObjectPath;
 class Response;
 class ErrorResponse;
 }  // namespace dbus

diff --git a/device/bluetooth/dbus/fake_bluetooth_gatt_application_service_provider.h b/device/bluetooth/dbus/fake_bluetooth_gatt_application_service_provider.h
@@ -19,8 +19,6 @@
 
 namespace bluez {
 
-class BluetoothLocalGattCharacteristicBlueZ;
-class BluetoothLocalGattDescriptorBlueZ;
 class BluetoothLocalGattServiceBlueZ;
 
 // FakeBluetoothGattApplicationServiceProvider simulates behavior of a local

diff --git a/device/bluetooth/test/bluetooth_test_android.h b/device/bluetooth/test/bluetooth_test_android.h
@@ -12,8 +12,6 @@
 
 namespace device {
 
-class BluetoothAdapterAndroid;
-
 // Android implementation of BluetoothTestBase.
 class BluetoothTestAndroid : public BluetoothTestBase {
  public:

diff --git a/device/bluetooth/test/bluetooth_test_win.h b/device/bluetooth/test/bluetooth_test_win.h
@@ -16,7 +16,6 @@
 
 namespace device {
 class BluetoothAdapterWin;
-class BluetoothRemoteGattCharacteristicWin;
 
 // Windows implementation of BluetoothTestBase.
 class BluetoothTestWin : public BluetoothTestBase,

diff --git a/device/gamepad/gamepad_test_helpers.h b/device/gamepad/gamepad_test_helpers.h
@@ -17,8 +17,6 @@
 
 namespace device {
 
-class GamepadService;
-
 // Data fetcher that returns canned data for the gamepad provider.
 class MockGamepadDataFetcher : public GamepadDataFetcher {
  public:

diff --git a/device/generic_sensor/platform_sensor_ambient_light_mac.h b/device/generic_sensor/platform_sensor_ambient_light_mac.h
@@ -11,10 +11,6 @@
 #include "base/mac/scoped_ioobject.h"
 #include "device/generic_sensor/platform_sensor.h"
 
-namespace base {
-class SingleThreadTaskRunner;
-}
-
 namespace device {
 
 // Implementation of PlatformSensor for macOS to query the ambient light sensor.

diff --git a/device/generic_sensor/platform_sensor_android.h b/device/generic_sensor/platform_sensor_android.h
@@ -9,10 +9,6 @@
 #include "base/android/scoped_java_ref.h"
 #include "base/memory/ref_counted.h"
 
-namespace base {
-class SingleThreadTaskRunner;
-}
-
 namespace device {
 
 class PlatformSensorAndroid : public PlatformSensor {

diff --git a/device/hid/hid_service_linux.h b/device/hid/hid_service_linux.h
@@ -17,8 +17,6 @@
 
 namespace device {
 
-class HidConnection;
-
 class HidServiceLinux : public HidService {
  public:
   HidServiceLinux(scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner);

diff --git a/device/hid/hid_service_mac.h b/device/hid/hid_service_mac.h
@@ -23,8 +23,6 @@ class SingleThreadTaskRunner;
 
 namespace device {
 
-class HidConnection;
-
 class HidServiceMac : public HidService {
  public:
   HidServiceMac(scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner);

diff --git a/device/hid/hid_service_win.h b/device/hid/hid_service_win.h
@@ -23,12 +23,6 @@ extern "C" {
 #include "device/hid/hid_device_info.h"
 #include "device/hid/hid_service.h"
 
-namespace base {
-namespace win {
-class MessageWindow;
-}
-}
-
 namespace device {
 
 class HidServiceWin : public HidService, public DeviceMonitorWin::Observer {

diff --git a/device/udev_linux/udev_linux.h b/device/udev_linux/udev_linux.h
@@ -48,7 +48,6 @@
 extern "C" {
 struct udev;
 struct udev_device;
-struct udev_monitor;
 }
 
 namespace device {

diff --git a/device/usb/mojo/device_impl.h b/device/usb/mojo/device_impl.h
@@ -20,10 +20,6 @@
 #include "mojo/public/cpp/bindings/binding.h"
 #include "mojo/public/cpp/bindings/interface_request.h"
 
-namespace net {
-class IOBuffer;
-}
-
 namespace device {
 namespace usb {
 

diff --git a/device/usb/mojo/device_manager_impl.h b/device/usb/mojo/device_manager_impl.h
@@ -19,15 +19,9 @@
 #include "mojo/public/cpp/bindings/array.h"
 #include "mojo/public/cpp/bindings/interface_request.h"
 
-namespace base {
-class SequencedTaskRunner;
-}
-
 namespace device {
 
 class UsbDevice;
-class UsbDeviceFilter;
-class UsbDeviceHandle;
 
 namespace usb {
 

diff --git a/device/usb/usb_device_handle_impl.h b/device/usb/usb_device_handle_impl.h
@@ -38,7 +38,6 @@ struct EndpointMapValue {
 };
 
 class UsbContext;
-struct UsbConfigDescriptor;
 class UsbDeviceImpl;
 
 typedef libusb_device_handle* PlatformUsbDeviceHandle;

diff --git a/device/usb/usb_device_impl.h b/device/usb/usb_device_impl.h
@@ -30,10 +30,6 @@ namespace base {
 class SequencedTaskRunner;
 }
 
-namespace dbus {
-class FileDescriptor;
-}
-
 namespace device {
 
 class UsbDeviceHandleImpl;

diff --git a/device/usb/usb_device_linux.h b/device/usb/usb_device_linux.h
@@ -23,7 +23,6 @@ class SequencedTaskRunner;
 
 namespace device {
 
-struct UsbConfigDescriptor;
 struct UsbDeviceDescriptor;
 
 class UsbDeviceLinux : public UsbDevice {

diff --git a/device/usb/usb_service_impl.h b/device/usb/usb_service_impl.h
@@ -27,7 +27,6 @@ struct libusb_context;
 
 namespace base {
 class SequencedTaskRunner;
-class SingleThreadTaskRunner;
 }
 
 namespace device {

diff --git a/device/usb/usb_service_linux.h b/device/usb/usb_service_linux.h
@@ -12,7 +12,6 @@
 
 namespace base {
 class SequencedTaskRunner;
-class SingleThreadTaskRunner;
 }
 
 namespace device {

diff --git a/device/vr/android/gvr/gvr_device_provider.h b/device/vr/android/gvr/gvr_device_provider.h
@@ -16,10 +16,8 @@
 
 namespace device {
 
-class GvrDelegateProvider;
 class GvrDelegate;
 class GvrDevice;
-class VRServiceImpl;
 
 class DEVICE_VR_EXPORT GvrDeviceProvider : public VRDeviceProvider {
  public:

diff --git a/device/vr/vr_device.h b/device/vr/vr_device.h
@@ -9,14 +9,6 @@
 #include "device/vr/vr_export.h"
 #include "device/vr/vr_service.mojom.h"
 
-namespace blink {
-struct WebHMDSensorState;
-}
-
-namespace ui {
-class BaseWindow;
-}
-
 namespace device {
 
 class VRDisplayImpl;

diff --git a/device/vr/vr_device_provider.h b/device/vr/vr_device_provider.h
@@ -10,7 +10,6 @@
 namespace device {
 
 class VRDevice;
-class VRServiceImpl;
 
 class VRDeviceProvider {
  public: