Skip to content

Commit

Permalink
WeakPtr requires SequencedTaskRunner, correct interface in blimp_clie…
Browse files Browse the repository at this point in the history
…nt_session.cc

The caller is already using a SequencedTaskRunner but it's incorrect for this
interface to allow a plain TaskRunner per its use of WeakPtr.

BUG=618043

Review-Url: https://codereview.chromium.org/2085173003
Cr-Commit-Position: refs/heads/master@{#401431}
  • Loading branch information
gab authored and Commit bot committed Jun 22, 2016
1 parent f300d68 commit 9f79bb5
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions blimp/client/session/blimp_client_session.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include "base/command_line.h"
#include "base/memory/ptr_util.h"
#include "base/numerics/safe_conversions.h"
#include "base/sequenced_task_runner.h"
#include "base/strings/string_number_conversions.h"
#include "base/threading/sequenced_task_runner_handle.h"
#include "base/threading/thread_task_runner_handle.h"
Expand Down Expand Up @@ -46,7 +47,7 @@ class CrossThreadNetworkEventObserver : public NetworkEventObserver {
public:
CrossThreadNetworkEventObserver(
const base::WeakPtr<NetworkEventObserver>& target,
const scoped_refptr<base::TaskRunner>& task_runner)
const scoped_refptr<base::SequencedTaskRunner>& task_runner)
: target_(target), task_runner_(task_runner) {}

~CrossThreadNetworkEventObserver() override {}
Expand All @@ -64,7 +65,9 @@ class CrossThreadNetworkEventObserver : public NetworkEventObserver {

private:
base::WeakPtr<NetworkEventObserver> target_;
scoped_refptr<base::TaskRunner> task_runner_;
scoped_refptr<base::SequencedTaskRunner> task_runner_;

DISALLOW_COPY_AND_ASSIGN(CrossThreadNetworkEventObserver);
};

} // namespace
Expand Down

0 comments on commit 9f79bb5

Please sign in to comment.