Skip to content

Commit

Permalink
Remove/replace unnecessary logging.h includes in .cc files (rlz)
Browse files Browse the repository at this point in the history
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved
to the much smaller headers check.h, check_op.h, and notreached.h,
respectively.

This CL updates .cc files to use those headers instead when
possible, with the purpose of saving compile time.

(Split out from https://crrev.com/c/2164525 which also has
notes on how the change was generated.)

Bug: 1031540
Change-Id: I054e9ccfcbe6417607237e46a42622194956f1eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164513
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763464}
  • Loading branch information
zmodem authored and Commit Bot committed Apr 28, 2020
1 parent 91082e6 commit a124a2e
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 8 deletions.
1 change: 0 additions & 1 deletion rlz/lib/crc32_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include "rlz/lib/crc32.h"

#include "base/logging.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"

Expand Down
1 change: 0 additions & 1 deletion rlz/lib/crc8_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include <stddef.h>

#include "base/logging.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"

Expand Down
1 change: 0 additions & 1 deletion rlz/lib/financial_ping_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

#include <stdint.h>

#include "base/logging.h"
#include "base/stl_util.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
Expand Down
1 change: 0 additions & 1 deletion rlz/lib/lib_values_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

#include "rlz/lib/lib_values.h"

#include "base/logging.h"
#include "rlz/lib/assert.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
Expand Down
1 change: 0 additions & 1 deletion rlz/lib/rlz_lib_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#include <memory>

#include "base/bind.h"
#include "base/logging.h"
#include "base/message_loop/message_pump_type.h"
#include "base/posix/eintr_wrapper.h"
#include "base/strings/stringprintf.h"
Expand Down
1 change: 0 additions & 1 deletion rlz/lib/string_utils_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

#include <stddef.h>

#include "base/logging.h"
#include "base/stl_util.h"
#include "base/strings/utf_string_conversions.h"
#include "rlz/lib/assert.h"
Expand Down
1 change: 0 additions & 1 deletion rlz/mac/lib/machine_id_mac.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include <stddef.h>
#include <stdint.h>

#include "base/logging.h"
#include "base/mac/foundation_util.h"
#include "base/mac/mac_util.h"
#include "base/mac/scoped_cftyperef.h"
Expand Down
1 change: 0 additions & 1 deletion rlz/win/lib/machine_deal_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

#include "rlz/win/lib/machine_deal.h"

#include "base/logging.h"
#include "rlz/lib/machine_deal_win.h"
#include "rlz/test/rlz_test_helpers.h"
#include "testing/gmock/include/gmock/gmock.h"
Expand Down

0 comments on commit a124a2e

Please sign in to comment.