Skip to content

Commit

Permalink
Add DEPS rules to help enforce the general rule that the embedder sho…
Browse files Browse the repository at this point in the history
…uld provide URLs and access tokens to server-side services.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/11573034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173538 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
joi@chromium.org committed Dec 17, 2012
1 parent 1450619 commit a1a705e
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 2 deletions.
14 changes: 12 additions & 2 deletions content/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ include_rules = [
"+content/shell", # for content_browsertests
"+content/test",

"+google_apis",

"+grit/content_resources.h",
"+grit/ui_resources.h",
"+grit/webkit_chromium_resources.h",
Expand All @@ -31,6 +29,18 @@ include_rules = [
"+sandbox",
"+skia",

# In general, content/ should not rely on google_apis, since URLs
# and access tokens should usually be provided by the
# embedder.
#
# There are a couple of specific parts of content that are excepted
# from this rule, see content/browser/speech/DEPS and
# content/browser/geolocation/DEPS. Both of these are cases of
# implementations that are strongly tied to Google servers, i.e. we
# don't expect alternate implementations to be provided by the
# embedder.
"-google_apis",

# Don't allow inclusion of these other libs we shouldn't be calling directly.
"-v8",
"-tools",
Expand Down
4 changes: 4 additions & 0 deletions content/browser/geolocation/DEPS
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
include_rules = [
"+google_apis", # Exception to general rule, see content/DEPS for details.
]

1 change: 1 addition & 0 deletions content/browser/speech/DEPS
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
include_rules = [
"+google_apis", # Exception to general rule, see content/DEPS for details.
"+media/audio", # For audio input.
]

0 comments on commit a1a705e

Please sign in to comment.