Skip to content

Commit

Permalink
[Code health] Fix gn check for //extensions/browser/api/clipboard
Browse files Browse the repository at this point in the history
Bug: 1158941
Change-Id: Iac4c4b0c662d556100a908ab4f878237fb810b21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611697
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841336}
  • Loading branch information
Evan Stade authored and Chromium LUCI CQ committed Jan 8, 2021
1 parent 02e9b76 commit a41a7b0
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
1 change: 0 additions & 1 deletion .gn
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ no_check_targets = [
"//extensions/browser/api/bluetooth_socket:*", # 12 errors
"//extensions/browser/api/cast_channel:*", # 3 errors
"//extensions/browser/api/cec_private:*", # 4 errors
"//extensions/browser/api/clipboard:*", # 3 errors
"//extensions/browser/api/declarative:*", # 20 errors
"//extensions/browser/api/declarative_content:*", # 2 errors
"//extensions/browser/api/declarative_net_request:*", # 18 errors
Expand Down
6 changes: 5 additions & 1 deletion extensions/browser/api/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,9 @@ source_set("api") {
"media_perception_private/media_perception_private_api.h",
]

# TODO(crbug/1158984): as above, remove these deps.
public_deps += [
"//extensions/browser/api/cec_private",
"//extensions/browser/api/clipboard",
"//extensions/browser/api/diagnostics",
"//extensions/browser/api/virtual_keyboard",
"//extensions/browser/api/vpn_provider",
Expand Down Expand Up @@ -207,6 +207,10 @@ group("api_implementations") {
"//extensions/browser/api/virtual_keyboard_private",
"//extensions/browser/api/web_request",
]

if (is_chromeos_ash) {
public_deps += [ "//extensions/browser/api/clipboard" ]
}
}

function_registration("api_registration") {
Expand Down
6 changes: 5 additions & 1 deletion extensions/browser/api/clipboard/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ source_set("clipboard") {
"clipboard_api.h",
]

deps = [ "//extensions/common/api" ]
deps = [
"//extensions/browser/api",
"//extensions/common/api",
"//ui/base/clipboard",
]

public_deps = [ "//extensions/browser:browser_sources" ]
}

0 comments on commit a41a7b0

Please sign in to comment.