Skip to content

Commit

Permalink
Revert of [KeyEvent Mac] Move WebInputEventFactory into chromium. (pa…
Browse files Browse the repository at this point in the history
…tchset chromium#9 id:160001 of https://codereview.chromium.org/1331013004/ )

Reason for revert:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9%20%28retina%29/builds/6032
../../content/browser/renderer_host/input/web_input_event_builders_mac.mm:889:10: error: use of undeclared identifier 'NSEventTypeSmartMagnify'; did you mean 'NSEventTypeMagnify'?
    case NSEventTypeSmartMagnify:
         ^~~~~~~~~~~~~~~~~~~~~~~
         NSEventTypeMagnify

Original issue's description:
> [KeyEvent Mac] Move WebInputEventFactory into chromium.
>
> There was an inconsistency on the Mac platform that the WebInputEventFactory
> (old WebKit code) was being used. Other platforms have migrated to using
> builders and it was weird for the Mac code path to have some code on one
> side of the blink divide that others didn't. This change brings the Mac
> platform inline with the others by moving the input event
> factory from blink into chromium.
>
> blink change: https://codereview.chromium.org/1335673002/
>
> BUG=493833,237267
>
> Committed: https://crrev.com/8db5ca887d4560ed15bf5e6e2dce69dc85868f25
> Cr-Commit-Position: refs/heads/master@{#348989}
>
> Committed: https://crrev.com/5405b8306550f01b86204d45fad3360593b39001
> Cr-Commit-Position: refs/heads/master@{#349157}

TBR=wez@chromium.org,sadrul@chromium.org,asvitkine@chromium.org,mnaganov@chromium.org,piman@chromium.org,thakis@chromium.org,dtapuska@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=493833,237267

Review URL: https://codereview.chromium.org/1348843002

Cr-Commit-Position: refs/heads/master@{#349172}
  • Loading branch information
skobes-chromium authored and Commit bot committed Sep 16, 2015
1 parent 9681cc8 commit a61cdca
Show file tree
Hide file tree
Showing 14 changed files with 43 additions and 1,162 deletions.
3 changes: 3 additions & 0 deletions content/browser/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ include_rules = [
"+third_party/WebKit/public/web/WebTreeScopeType.h",
"+third_party/WebKit/public/web/mac/WebScrollbarTheme.h",

# These should be burned down. http://crbug.com/237267
"!third_party/WebKit/public/web/mac/WebInputEventFactory.h",

# DO NOT ADD ANY CHROME OR COMPONENTS INCLUDES HERE!!!
# See https://sites.google.com/a/chromium.org/dev/developers/content-module
# for more information.
Expand Down
41 changes: 0 additions & 41 deletions content/browser/renderer_host/input/web_input_event_builders_mac.h

This file was deleted.

Loading

0 comments on commit a61cdca

Please sign in to comment.