Skip to content

Commit

Permalink
Add Gold dryrun usage to Blink web tests
Browse files Browse the repository at this point in the history
Adds a dryrun usage of Skia Gold to the pixel tests in the Blink web
tests. Data will be uploaded to Gold as if it were being used for
image comparisons, but any output or exceptions will be ignored. This
is so that the Gold team can see what sort of data the web tests are
producing in order to help determine whether Gold can be adapted to
meet the tests' needs.

Test runtime with this patch vs. without seems to be within margin
of error (+/- a few minutes per bot), so this is not expected to have
any noticeable impact on testing.

Bug: 1290526
Change-Id: Iee484e59c45fd1eef2c4cd1b1c563358eafe653b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312012
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#969203}
  • Loading branch information
Brian Sheedy authored and Chromium LUCI CQ committed Feb 10, 2022
1 parent 45ec3b5 commit a689814
Show file tree
Hide file tree
Showing 22 changed files with 1,041 additions and 193 deletions.
4 changes: 4 additions & 0 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -1168,6 +1168,7 @@ if (!is_ios) {
}

data = [
"//build/skia_gold_common/",
"//testing/scripts/common.py",
"//testing/scripts/run_isolated_script_test.py",
"//testing/xvfb.py",
Expand All @@ -1181,6 +1182,7 @@ if (!is_ios) {
"//third_party/pywebsocket3/src/mod_pywebsocket/",
"//third_party/test_fonts/test_fonts/",
"//third_party/wpt_tools/",
"//tools/skia_goldctl/",
]

if (is_win) {
Expand Down Expand Up @@ -1467,6 +1469,7 @@ if (!is_ios) {
"//build/android/",
"//build/gn_helpers.py",
"//build/config/gclient_args.gni",
"//build/skia_gold_common/",
"//components/crash/content/tools/generate_breakpad_symbols.py",
"//testing/unexpected_passes_common/",
"//third_party/blink/renderer/bindings/scripts/",
Expand All @@ -1490,6 +1493,7 @@ if (!is_ios) {
"//third_party/depot_tools/pylintrc",
"//third_party/ply/",
"//tools/idl_parser/",
"//tools/skia_goldctl/",
]
}
}
Expand Down
28 changes: 23 additions & 5 deletions testing/buildbot/chromium.clang.json
Original file line number Diff line number Diff line change
Expand Up @@ -9982,6 +9982,7 @@
{
"args": [
"--num-retries=3",
"--git-revision=${got_revision}",
"--platform=fuchsia"
],
"isolate_name": "blink_web_tests",
Expand All @@ -9992,6 +9993,11 @@
"script": "//third_party/blink/tools/merge_web_test_results.py"
},
"name": "blink_web_tests",
"precommit_args": [
"--gerrit-issue=${patch_issue}",
"--gerrit-patchset=${patch_set}",
"--buildbucket-id=${buildbucket_build_id}"
],
"resultdb": {
"enable": true
},
Expand All @@ -10004,7 +10010,7 @@
"os": "Ubuntu-16.04"
}
],
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
"service_account": "chrome-gold@chops-service-accounts.iam.gserviceaccount.com"
},
"test_id_prefix": "ninja://:blink_web_tests/"
},
Expand Down Expand Up @@ -23087,7 +23093,8 @@
},
{
"args": [
"--num-retries=3"
"--num-retries=3",
"--git-revision=${got_revision}"
],
"isolate_name": "blink_web_tests",
"merge": {
Expand All @@ -23097,6 +23104,11 @@
"script": "//third_party/blink/tools/merge_web_test_results.py"
},
"name": "blink_web_tests",
"precommit_args": [
"--gerrit-issue=${patch_issue}",
"--gerrit-patchset=${patch_set}",
"--buildbucket-id=${buildbucket_build_id}"
],
"resultdb": {
"enable": true
},
Expand All @@ -23109,7 +23121,7 @@
"os": "Mac-10.15"
}
],
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com",
"service_account": "chrome-gold@chops-service-accounts.iam.gserviceaccount.com",
"shards": 12
},
"test_id_prefix": "ninja://:blink_web_tests/"
Expand Down Expand Up @@ -26668,7 +26680,8 @@
},
{
"args": [
"--num-retries=3"
"--num-retries=3",
"--git-revision=${got_revision}"
],
"isolate_name": "blink_web_tests",
"merge": {
Expand All @@ -26678,6 +26691,11 @@
"script": "//third_party/blink/tools/merge_web_test_results.py"
},
"name": "blink_web_tests",
"precommit_args": [
"--gerrit-issue=${patch_issue}",
"--gerrit-patchset=${patch_set}",
"--buildbucket-id=${buildbucket_build_id}"
],
"resultdb": {
"enable": true
},
Expand All @@ -26691,7 +26709,7 @@
"pool": "chrome.tests"
}
],
"service_account": "chrome-tester@chops-service-accounts.iam.gserviceaccount.com",
"service_account": "chrome-gold@chops-service-accounts.iam.gserviceaccount.com",
"shards": 12
},
"test_id_prefix": "ninja://:blink_web_tests/"
Expand Down
Loading

0 comments on commit a689814

Please sign in to comment.