Fallback to app_name_ when app_id_ is empty, which could happen before

UpdateCurrentAppInfo or in AndroidTV builds. Review URL: https://codereview.chromium.org/794213003 Cr-Commit-Position: refs/heads/master@{#308598}
Denger-Network · Dec 16, 2014 · a6fbe42 · a6fbe42
1 parent da8e8a8
commit a6fbe42
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/chromecast/base/metrics/cast_metrics_helper.cc b/chromecast/base/metrics/cast_metrics_helper.cc
@@ -136,13 +136,19 @@ void CastMetricsHelper::UpdateCurrentAppInfo(const std::string& app_id,
 void CastMetricsHelper::LogMediaPlay() {
   MAKE_SURE_THREAD(LogMediaPlay);
   RecordSimpleAction(EncodeAppInfoIntoMetricsName(
-      "MediaPlay", app_id_, session_id_, sdk_version_));
+      "MediaPlay",
+      app_id_.empty() ? app_name_ : app_id_,
+      session_id_,
+      sdk_version_));
 }
 
 void CastMetricsHelper::LogMediaPause() {
   MAKE_SURE_THREAD(LogMediaPause);
   RecordSimpleAction(EncodeAppInfoIntoMetricsName(
-      "MediaPause", app_id_, session_id_, sdk_version_));
+      "MediaPause",
+      app_id_.empty() ? app_name_ : app_id_,
+      session_id_,
+      sdk_version_));
 }
 
 void CastMetricsHelper::LogTimeToDisplayVideo() {