Skip to content

Commit

Permalink
MojoLPM: fix bug in TestCase::Run
Browse files Browse the repository at this point in the history
Similarly to checking the size of actions, we need to check the size of
the sequences to make sure those are not empty. Otherwise, we end up
having a DIVINT on line 676.

Change-Id: I20c847a07e5b0760a0ee9cf7a895b6c9f1952997
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4738599
Commit-Queue: Paul Semel <paulsemel@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/main@{#1178309}
  • Loading branch information
Paul Semel authored and Chromium LUCI CQ committed Aug 2, 2023
1 parent c6e6f3d commit a92e510
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mojo/public/tools/fuzzers/mojolpm.h
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ template <typename ProtoTestcase,
bool Testcase<ProtoTestcase, ProtoAction, kMaxActionCount, kMaxActionSize>::
IsFinished() {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
if (!proto_testcase_.actions_size()) {
if (!proto_testcase_.actions_size() || !proto_testcase_.sequences_size()) {
return true;
}

Expand Down

0 comments on commit a92e510

Please sign in to comment.