Skip to content

Commit

Permalink
Include HWB support in devtools-frontend webtests.
Browse files Browse the repository at this point in the history
Re-enable two webtests that were temporarily disabled while adding
support for the HWB color format to the devtools frontend.
Additionally, add further tests for the new color format.

Fixed: 1288883
Change-Id: I1c3ca0a5077e419037236996e71bb1e8d871cd30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3516254
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#980845}
  • Loading branch information
Jan Keitel authored and Chromium LUCI CQ committed Mar 14, 2022
1 parent bd72251 commit a9f36c4
Show file tree
Hide file tree
Showing 5 changed files with 188 additions and 17 deletions.
4 changes: 0 additions & 4 deletions third_party/blink/web_tests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -7651,10 +7651,6 @@ crbug.com/1229801 http/tests/devtools/elements/css-rule-hover-highlights-selecto
# Sheriff 2022-03-01
crbug.com/1302043 [ Linux ] virtual/plz-dedicated-worker/external/wpt/resource-timing/object-not-found-after-cross-origin-redirect.html [ Pass Timeout ]

# Temporarily disable to land related CL in DevTools
crbug.com/1288883 http/tests/devtools/elements/styles-3/spectrum.js [ Skip ]
crbug.com/1288883 http/tests/devtools/elements/styles-4/styles-invalid-color-values.js [ Skip ]

# Sheriff 2022-03-03
crbug.com/1302571 virtual/threaded/http/tests/devtools/isolated-code-cache/cross-origin-test.js [ Skip ]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,14 @@ Testing: hsl(1 100% 50% / 20%)
hsl(1deg 100% 50% / 20%)
Testing: hsL(1deg 100% 50% / 20%)
hsl(1deg 100% 50% / 20%)
Testing: hwb(1 100% 50%)
hwb(0deg 67% 33%)
Testing: hwb(100grad 100% 50% / 0.2)
hwb(0deg 67% 33% / 20%)
Testing: hwb(1rad 20% 50% / 20%)
hwb(57deg 20% 50% / 20%)
Testing: hwB(1deg 20% 50% / 20%)
hwb(1deg 20% 50% / 20%)
--- Testing alpha changes
Testing: red
#ff000000
Expand Down Expand Up @@ -66,6 +74,14 @@ Testing: hsl(1 100% 50% / 20%)
hsl(1deg 100% 50% / 0%)
Testing: hsL(1deg 100% 50% / 20%)
hsl(1deg 100% 50% / 0%)
Testing: hwb(1 100% 50%)
hwb(0deg 67% 33% / 0%)
Testing: hwb(100grad 100% 50% / 0.2)
hwb(0deg 67% 33% / 0%)
Testing: hwb(1rad 20% 50% / 20%)
hwb(57deg 20% 50% / 0%)
Testing: hwB(1deg 20% 50% / 20%)
hwb(1deg 20% 50% / 0%)
--- Testing _formatViewSwitch()
Testing: red
rgb
Expand All @@ -84,35 +100,47 @@ rgb
hsl
Testing: rgb(1, 2, 3)
hsl
hex
hwb
Testing: rgba(1, 2, 3, 0.2)
hsl
hex
hwb
Testing: rgb(1, 2, 3, 0.2)
hsl
hex
hwb
Testing: rgb(1 2 3 / 20%)
hsl
hex
hwb
Testing: rgbA(1 2 3)
hsl
hex
hwb
Testing: rgba(1.5 2.6 3.1)
hsl
hex
hwb
Testing: hsl(1, 100%, 50%)
hwb
hex
rgb
Testing: hsl(1 100% 50%)
hwb
hex
rgb
Testing: hsla(1, 100%, 50%, 0.2)
hwb
hex
rgb
Testing: hsl(1 100% 50% / 20%)
hwb
hex
rgb
Testing: hsL(1deg 100% 50% / 20%)
hwb
hex
Testing: hwb(1 100% 50%)
hex
rgb
Testing: hwb(100grad 100% 50% / 0.2)
hex
rgb
Testing: hwb(1rad 20% 50% / 20%)
hex
rgb
Testing: hwB(1deg 20% 50% / 20%)
hex
rgb

Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@
{string: 'rgb(1 2 3 / 20%)', format: cf.RGB}, {string: 'rgbA(1 2 3)', format: cf.RGB},
{string: 'rgba(1.5 2.6 3.1)', format: cf.RGB}, {string: 'hsl(1, 100%, 50%)', format: cf.HSL},
{string: 'hsl(1 100% 50%)', format: cf.HSL}, {string: 'hsla(1, 100%, 50%, 0.2)', format: cf.HSLA},
{string: 'hsl(1 100% 50% / 20%)', format: cf.HSL}, {string: 'hsL(1deg 100% 50% / 20%)', format: cf.HSL}
{string: 'hsl(1 100% 50% / 20%)', format: cf.HSL}, {string: 'hsL(1deg 100% 50% / 20%)', format: cf.HSL},
{string: 'hwb(1 100% 50%)', format: cf.HWB}, {string: 'hwb(100grad 100% 50% / 0.2)', format: cf.HWB},
{string: 'hwb(1rad 20% 50% / 20%)', format: cf.HWB}, {string: 'hwB(1deg 20% 50% / 20%)', format: cf.HWB}
];

TestRunner.addResult('--- Testing colorString()');
Expand Down
Loading

0 comments on commit a9f36c4

Please sign in to comment.