Skip to content

Commit

Permalink
Revert "Remove incorrect named builders ("_" underscores)"
Browse files Browse the repository at this point in the history
This reverts commit 7d53bc2.

Reason for revert: still referenced by cq.cfg.

Original change's description:
> Remove incorrect named builders ("_" underscores)
> 
> Bug: 868202
> Change-Id: I807807511df39b7a4eac3b699fcd2274d4d24138
> Reviewed-on: https://chromium-review.googlesource.com/c/1343081
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Eric Foo <efoo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609559}

TBR=hinoka@chromium.org,efoo@chromium.org,jbudorick@chromium.org

Change-Id: Ic530f835ef9367cda18f54be54dc712d3f229ded
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868202
Reviewed-on: https://chromium-review.googlesource.com/c/1345234
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609816}
  • Loading branch information
jbudorick authored and Commit Bot committed Nov 20, 2018
1 parent 02dfa05 commit aa4a004
Show file tree
Hide file tree
Showing 3 changed files with 81 additions and 0 deletions.
40 changes: 40 additions & 0 deletions infra/config/global/cr-buildbucket.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -3315,41 +3315,81 @@ buckets {
mixins: "linux"
mixins: "blink-try"
}
builders {
name: "linux_trusty_blink_rel"
mixins: "linux"
mixins: "blink-try"
}
builders {
name: "mac10.10-blink-rel"
mixins: "mac"
mixins: "blink-try"
}
builders {
name: "mac10.10_blink_rel"
mixins: "mac"
mixins: "blink-try"
}
builders {
name: "mac10.11-blink-rel"
mixins: "mac"
mixins: "blink-try"
}
builders {
name: "mac10.11_blink_rel"
mixins: "mac"
mixins: "blink-try"
}
builders {
name: "mac10.12-blink-rel"
mixins: "mac"
mixins: "blink-try"
}
builders {
name: "mac10.12_blink_rel"
mixins: "mac"
mixins: "blink-try"
}
builders {
name: "mac10.13-blink-rel"
mixins: "mac"
mixins: "blink-try"
}
builders {
name: "mac10.13_blink_rel"
mixins: "mac"
mixins: "blink-try"
}
builders {
name: "mac10.13_retina-blink-rel"
mixins: "mac"
mixins: "blink-try"
}
builders {
name: "mac10.13_retina_blink_rel"
mixins: "mac"
mixins: "blink-try"
}
builders {
name: "win10-blink-rel"
mixins: "win"
mixins: "blink-try"
}
builders {
name: "win10_blink_rel"
mixins: "win"
mixins: "blink-try"
}
builders {
name: "win7-blink-rel"
mixins: "win"
mixins: "blink-try"
}
builders {
name: "win7_blink_rel"
mixins: "win"
mixins: "blink-try"
}
}
}

Expand Down
32 changes: 32 additions & 0 deletions infra/config/global/luci-milo.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -4425,6 +4425,38 @@ consoles {
name: "buildbot/tryserver.blink/win7-blink-rel"
name: "buildbucket/luci.chromium.try/win7-blink-rel"
}
builders {
name: "buildbot/tryserver.blink/linux_trusty_blink_rel"
name: "buildbucket/luci.chromium.try/linux_trusty_blink_rel"
}
builders {
name: "buildbot/tryserver.blink/mac10.10_blink_rel"
name: "buildbucket/luci.chromium.try/mac10.10_blink_rel"
}
builders {
name: "buildbot/tryserver.blink/mac10.11_blink_rel"
name: "buildbucket/luci.chromium.try/mac10.11_blink_rel"
}
builders {
name: "buildbot/tryserver.blink/mac10.13_retina_blink_rel"
name: "buildbucket/luci.chromium.try/mac10.13_retina_blink_rel"
}
builders {
name: "buildbot/tryserver.blink/mac10.12_blink_rel"
name: "buildbucket/luci.chromium.try/mac10.12_blink_rel"
}
builders {
name: "buildbot/tryserver.blink/mac10.13_blink_rel"
name: "buildbucket/luci.chromium.try/mac10.13_blink_rel"
}
builders {
name: "buildbot/tryserver.blink/win10_blink_rel"
name: "buildbucket/luci.chromium.try/win10_blink_rel"
}
builders {
name: "buildbot/tryserver.blink/win7_blink_rel"
name: "buildbucket/luci.chromium.try/win7_blink_rel"
}
builder_view_only: true
}

Expand Down
9 changes: 9 additions & 0 deletions tools/mb/mb_config.pyl
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,15 @@
'mac10.13_retina-blink-rel': 'release_bot_minimal_symbols',
'win7-blink-rel': 'release_bot_x86_minimal_symbols',
'win10-blink-rel': 'release_bot_x86_minimal_symbols',
# TODO(dpranke): Delete all the old names once things have been updated.
'linux_trusty_blink_rel': 'release_bot_minimal_symbols',
'mac10.10_blink_rel': 'release_bot_minimal_symbols',
'mac10.11_blink_rel': 'release_bot_minimal_symbols',
'mac10.12_blink_rel': 'release_bot_minimal_symbols',
'mac10.13_blink_rel': 'release_bot_minimal_symbols',
'mac10.13_retina_blink_rel': 'release_bot_minimal_symbols',
'win7_blink_rel': 'release_bot_x86_minimal_symbols',
'win10_blink_rel': 'release_bot_x86_minimal_symbols',
},

'tryserver.chromium.android': {
Expand Down

0 comments on commit aa4a004

Please sign in to comment.