Skip to content

Commit

Permalink
[fuchsia] Fix remaining per-file OWNERS entries to apply to subdirect…
Browse files Browse the repository at this point in the history
…ories

Asterisk ('*') does not match strings that include slashes. Replace such
instances for platform-specific owners with "...".

There were some instances of '*' that really did intend to apply to
files in the current directory or only applied to a single directory.
* //net/base/OWNERS is unchanged
* The entry in //third_party/blink/tools/OWNERS has been moved to a
  subdirectory.

Also removes a non-committer from //skia/OWNERS.

Bug: 1244995
Change-Id: Ife57feee67522d435c80bc545e7a5b16c4a66431
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3151419
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Will Cassella <cassew@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Auto-Submit: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/main@{#921223}
  • Loading branch information
ddorwin authored and Chromium LUCI CQ committed Sep 14, 2021
1 parent 147dd60 commit ac4e293
Show file tree
Hide file tree
Showing 9 changed files with 10 additions and 12 deletions.
2 changes: 1 addition & 1 deletion base/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ per-file *android*=file://base/android/OWNERS
per-file BUILD.gn=file://base/android/OWNERS

# For Fuchsia-specific changes:
per-file *_fuchsia*=file://build/fuchsia/OWNERS
per-file ..._fuchsia*=file://build/fuchsia/OWNERS

# For Windows-specific changes:
per-file *_win*=file://base/win/OWNERS
Expand Down
2 changes: 1 addition & 1 deletion chromecast/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ per-file *android*=file://chromecast/android/OWNERS
per-file *.java=file://chromecast/android/OWNERS

# Fuchsia integration owners:
per-file *fuchsia*=file://build/fuchsia/OWNERS
per-file ...fuchsia*=file://build/fuchsia/OWNERS

# For major changes, please use one of the reviewers above!
dnicoara@chromium.org
Expand Down
2 changes: 1 addition & 1 deletion content/test/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ per-file mock_platform_notification_service.*=file://content/browser/notificatio
per-file mock_badge_service.*=file://chrome/browser/badging/OWNERS

# Fuchsia related files.
per-file *fuchsia*=file://build/fuchsia/OWNERS
per-file ...fuchsia*=file://build/fuchsia/OWNERS

# WebContents-related test code.
per-file *web_contents*=file://content/browser/web_contents/OWNERS
Expand Down
2 changes: 1 addition & 1 deletion media/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ wolenetz@chromium.org
xhwang@chromium.org

# For Fuchsia-specific changes:
per-file *_fuchsia*=file://build/fuchsia/OWNERS
per-file ..._fuchsia*=file://build/fuchsia/OWNERS

# For GpuMemoryBuffer-related changes:
per-file *gpu_memory_buffer*=dcastagna@chromium.org
2 changes: 1 addition & 1 deletion mojo/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ rockot@google.com
rsesek@chromium.org

# For Fuchsia-specific changes:
per-file *_fuchsia*=file://build/fuchsia/OWNERS
per-file ..._fuchsia*=file://build/fuchsia/OWNERS
3 changes: 1 addition & 2 deletions skia/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ borenet@google.com
brianosman@google.com
bsalomon@google.com
bungeman@google.com
egdaniel@google.com
fmalita@chromium.org
michaelludwig@google.com
reed@google.com
Expand All @@ -13,4 +12,4 @@ senorblanco@chromium.org
thakis@chromium.org

# For Fuchsia-specific changes:
per-file *_fuchsia*=file://build/fuchsia/OWNERS
per-file ..._fuchsia*=file://build/fuchsia/OWNERS
3 changes: 0 additions & 3 deletions third_party/blink/tools/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,3 @@ rmhasan@google.com
smcgruer@chromium.org
tkent@chromium.org
wangxianzhu@chromium.org

# For Fuchsia related files
per-file *fuchsia.py=file://build/fuchsia/OWNERS
2 changes: 2 additions & 0 deletions third_party/blink/tools/blinkpy/web_tests/port/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# For Fuchsia related files
per-file fuchsia.py=file://build/fuchsia/OWNERS
4 changes: 2 additions & 2 deletions ui/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ per-file BUILD.gn=*
per-file ....xtb=file://tools/translation/TRANSLATION_OWNERS

# For Fuchsia-specific changes:
per-file *fuchsia*=file://build/fuchsia/OWNERS
per-file *scenic*=file://build/fuchsia/OWNERS
per-file ...fuchsia*=file://build/fuchsia/OWNERS
per-file ...scenic*=file://build/fuchsia/OWNERS

0 comments on commit ac4e293

Please sign in to comment.