Skip to content

Commit

Permalink
Update octane to use results.AddValue(...)
Browse files Browse the repository at this point in the history
BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/379613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281895 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
nednguyen@google.com committed Jul 9, 2014
1 parent a7166ab commit afb0e08
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion tools/perf/benchmarks/octane.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@
from telemetry.util import statistics
from telemetry.value import scalar


_GB = 1024 * 1024 * 1024


class _OctaneMeasurement(page_measurement.PageMeasurement):
def __init__(self):
super(_OctaneMeasurement, self).__init__()
Expand Down Expand Up @@ -69,7 +71,9 @@ def MeasurePage(self, page, tab, results):
if 'Skipped' not in score_and_name[1]:
name = score_and_name[0]
score = int(score_and_name[1])
results.Add(name, 'score', score, data_type='unimportant')
results.AddValue(scalar.ScalarValue(
results.current_page, name, 'score', score, important=False))

# Collect all test scores to compute geometric mean.
all_scores.append(score)
total = statistics.GeometricMean(all_scores)
Expand Down

0 comments on commit afb0e08

Please sign in to comment.