Reland "Create a feature flag for PDF portfolio"

This is a reland of commit 747748b. This CL removes the extra line in tools/metrics/histograms/enums.xml. Original change's description: > Create a feature flag for PDF portfolio > > Creates a feature flag `pdf-portfolio` which will be an indicator that > portfolio feature is enabled in the PDF viewer. Currently this flag is > a dummy flag that has not been linked to the actual feature yet. > > Bug: 177188 > Change-Id: Ief14cbdad785bad405bf402d3cb57b22314a07c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4651500 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Nigi <nigi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1164297} Bug: 177188 Change-Id: I5c37624ad198ec0a6f7efdfbbeb4d2f4c928fb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4661237 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Nigi <nigi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1167665}
Denger-Network · Jul 7, 2023 · b095640 · b095640
1 parent 8dfd0f1
commit b095640
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 0 deletions.
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
@@ -6766,6 +6766,10 @@ const FeatureEntry kFeatureEntries[] = {
      flag_descriptions::kAccessiblePDFFormDescription, kOsDesktop,
      FEATURE_VALUE_TYPE(chrome_pdf::features::kAccessiblePDFForm)},
 
+    {"pdf-portfolio", flag_descriptions::kPdfPortfolioName,
+     flag_descriptions::kPdfPortfolioDescription, kOsDesktop,
+     FEATURE_VALUE_TYPE(chrome_pdf::features::kPdfPortfolio)},
+
     {"pdf-use-skia-renderer", flag_descriptions::kPdfUseSkiaRendererName,
      flag_descriptions::kPdfUseSkiaRendererDescription, kOsDesktop,
      FEATURE_VALUE_TYPE(chrome_pdf::features::kPdfUseSkiaRenderer)},

diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
@@ -6310,6 +6310,11 @@
     "owners": [ "rhalavati", "//ui/accessibility/OWNERS" ],
     "expiry_milestone": 120
   },
+  {
+    "name": "pdf-portfolio",
+    "owners": [ "nigi", "//pdf/OWNERS" ],
+    "expiry_milestone": 130
+  },
   {
     "name": "pdf-use-skia-renderer",
     "owners": [ "nigi", "//pdf/OWNERS" ],

diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
@@ -40,6 +40,9 @@ const char kAccessiblePDFFormName[] = "Accessible PDF Forms";
 const char kAccessiblePDFFormDescription[] =
     "Enables accessibility support for PDF forms.";
 
+const char kPdfPortfolioName[] = "PDF portfolio";
+const char kPdfPortfolioDescription[] = "Enable PDF portfolio feature.";
+
 const char kPdfUseSkiaRendererName[] =
     "Use Skia Renderer. This flag will have no effect if the renderer choice "
     "is controlled by an enterprise policy.";

diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
@@ -55,6 +55,9 @@ extern const char kAcceleratedVideoEncodeDescription[];
 extern const char kAccessiblePDFFormName[];
 extern const char kAccessiblePDFFormDescription[];
 
+extern const char kPdfPortfolioName[];
+extern const char kPdfPortfolioDescription[];
+
 extern const char kPdfUseSkiaRendererName[];
 extern const char kPdfUseSkiaRendererDescription[];
 #endif

diff --git a/pdf/pdf_features.cc b/pdf/pdf_features.cc
@@ -23,6 +23,8 @@ BASE_FEATURE(kPdfPartialLoading,
              "PdfPartialLoading",
              base::FEATURE_DISABLED_BY_DEFAULT);
 
+BASE_FEATURE(kPdfPortfolio, "PdfPortfolio", base::FEATURE_DISABLED_BY_DEFAULT);
+
 BASE_FEATURE(kPdfUseSkiaRenderer,
              "PdfUseSkiaRenderer",
              base::FEATURE_DISABLED_BY_DEFAULT);

diff --git a/pdf/pdf_features.h b/pdf/pdf_features.h
@@ -16,6 +16,7 @@ namespace features {
 BASE_DECLARE_FEATURE(kAccessiblePDFForm);
 BASE_DECLARE_FEATURE(kPdfIncrementalLoading);
 BASE_DECLARE_FEATURE(kPdfPartialLoading);
+BASE_DECLARE_FEATURE(kPdfPortfolio);
 BASE_DECLARE_FEATURE(kPdfUseSkiaRenderer);
 BASE_DECLARE_FEATURE(kPdfXfaSupport);
 

diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
@@ -62782,6 +62782,7 @@ from previous Chrome versions.
   <int value="-526236814" label="WebAssemblyTiering:enabled"/>
   <int value="-523155003" label="PhoneHubCameraRoll:disabled"/>
   <int value="-523030434" label="EnableBackgroundBlur:enabled"/>
+  <int value="-522137246" label="PdfPortfolio:disabled"/>
   <int value="-521251533" label="PrivacyGuideAndroid:enabled"/>
   <int value="-520221221" label="UserDataSnapshot:enabled"/>
   <int value="-520004021" label="WebXRHitTest:disabled"/>
@@ -64243,6 +64244,7 @@ from previous Chrome versions.
       label="enable-manual-fallback-for-password-saving:disabled"/>
   <int value="238376121" label="AndroidImprovedBookmarks:disabled"/>
   <int value="238738258" label="AndroidAppIntegration:enabled"/>
+  <int value="238843287" label="PdfPortfolio:enabled"/>
   <int value="239330938" label="LauncherAppSort:enabled"/>
   <int value="240856309" label="MimeHandlerViewInCrossProcessFrame:enabled"/>
   <int value="241187301" label="BrowserTouchBar:disabled"/>