Skip to content

Commit

Permalink
components: Fix 'gn check' errors for autofill.
Browse files Browse the repository at this point in the history
Tested on Linux with the following command lines:

$ gn gen out-gn/Debug
$ gn check out-gn/Debug //components/autofill/*

BUG=367595, 376000
TEST=see above
R=brettw@chromium.org,isherman@chromium.org

Review URL: https://codereview.chromium.org/1206643002

Cr-Commit-Position: refs/heads/master@{#335748}
  • Loading branch information
tfarina authored and Commit bot committed Jun 23, 2015
1 parent 3d5616a commit b1a8740
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 0 deletions.
1 change: 1 addition & 0 deletions .gn
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ check_targets = [
"//cloud_print/*",

#"//components/*", # Lots of errors.
"//components/autofill/*",
"//components/bookmarks/*",
"//components/pref_registry/*",
"//components/undo/*",
Expand Down
1 change: 1 addition & 0 deletions components/autofill/content/common/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ static_library("common") {
"//ipc",
"//third_party/WebKit/public:blink_minimal",
"//ui/gfx",
"//ui/gfx/geometry",
"//ui/gfx/ipc",
"//url",
]
Expand Down
14 changes: 14 additions & 0 deletions components/autofill/core/browser/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,12 @@ static_library("browser") {
"//components/keyed_service/core",
"//components/os_crypt",
"//components/pref_registry",
"//components/rappor",
"//components/resources",
"//components/signin/core/browser",
"//components/signin/core/common",
"//components/strings",
"//components/sync_driver",
"//components/webdata/common",
"//google_apis",
"//net",
Expand Down Expand Up @@ -202,9 +205,13 @@ static_library("test_support") {
"//components/os_crypt",
"//components/pref_registry",
"//components/rappor",
"//components/rappor:test_support",
"//components/signin/core/browser",
"//components/signin/core/common",
"//google_apis:test_support",
"//skia",
"//testing/gtest",
"//ui/gfx/geometry",
]
}

Expand Down Expand Up @@ -249,15 +256,22 @@ source_set("unit_tests") {
":test_support",
"//base",
"//base:prefs",
"//base:prefs_test_support",
"//base/test:test_support",
"//components/autofill/core/common",
"//components/os_crypt",
"//components/rappor:test_support",
"//components/resources",
"//components/signin/core/browser",
"//components/signin/core/browser:test_support",
"//components/signin/core/common",
"//components/strings",
"//components/sync_driver",
"//components/variations",
"//components/webdata/common",
"//components/webdata_services:test_support",
"//google_apis",
"//google_apis:test_support",
"//net:test_support",
"//sql",
"//sync",
Expand Down
1 change: 1 addition & 0 deletions components/autofill/core/common/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ source_set("unit_tests") {
":common",
"//base",
"//base:i18n",
"//components/autofill/core/browser",
"//testing/gmock",
"//testing/gtest",
"//url",
Expand Down

0 comments on commit b1a8740

Please sign in to comment.