Ban [w]ctype.h: net/

Bug: 1361094 Change-Id: If1e06a04f413ba32821957cb66aa560401b78e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4749580 Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1179313}
Denger-Network · Aug 3, 2023 · b49cd8d · b49cd8d
1 parent 55b614c
commit b49cd8d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/net/base/prioritized_dispatcher_unittest.cc b/net/base/prioritized_dispatcher_unittest.cc
@@ -4,8 +4,6 @@
 
 #include "net/base/prioritized_dispatcher.h"
 
-#include <ctype.h>
-
 #include <memory>
 #include <string>
 

diff --git a/net/socket/socket_test_util.cc b/net/socket/socket_test_util.cc
@@ -47,6 +47,7 @@
 #include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/abseil-cpp/absl/strings/ascii.h"
 
 #if BUILDFLAG(IS_ANDROID)
 #include "base/android/build_info.h"
@@ -68,9 +69,7 @@ inline char AsciifyLow(char x) {
 }
 
 inline char Asciify(char x) {
-  if ((x < 0) || !isprint(x))
-    return '.';
-  return x;
+  return absl::ascii_isprint(static_cast<unsigned char>(x)) ? x : '.';
 }
 
 void DumpData(const char* data, int data_len) {