Skip to content

Commit

Permalink
Restore some DCHECKs in child process launcher.
Browse files Browse the repository at this point in the history
BUG=1314491,469248

Change-Id: I22e7466635dae7a44c3a4b49d2fe20c021bb0825
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3580128
Auto-Submit: Will Harris <wfh@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#990864}
  • Loading branch information
wfh-chromium authored and Chromium LUCI CQ committed Apr 11, 2022
1 parent 87af3ad commit b4b5f06
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions content/browser/child_process_launcher.cc
Original file line number Diff line number Diff line change
Expand Up @@ -135,14 +135,12 @@ void ChildProcessLauncher::Notify(ChildProcessLauncherHelper::Process process,
}

bool ChildProcessLauncher::IsStarting() {
// TODO(crbug.com/469248): This fails in some tests.
// DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
return starting_;
}

const base::Process& ChildProcessLauncher::GetProcess() const {
// TODO(crbug.com/469248): This fails in some tests.
// DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
return process_.process;
}

Expand Down

0 comments on commit b4b5f06

Please sign in to comment.