Skip to content

Commit

Permalink
Fix some IWYU errors in advance of removing some #includes.
Browse files Browse the repository at this point in the history
Bug: 242216
Change-Id: Ia2b406e86e4989be41f9213e16f6c0bc04990aa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3009974
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Owners-Override: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898962}
  • Loading branch information
pkasting authored and Chromium LUCI CQ committed Jul 6, 2021
1 parent 5d2531d commit b4ee337
Show file tree
Hide file tree
Showing 145 changed files with 261 additions and 25 deletions.
1 change: 1 addition & 0 deletions android_webview/browser/cookie_manager.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

#include "base/android/scoped_java_ref.h"
#include "base/containers/circular_deque.h"
#include "base/files/file_path.h"
#include "base/no_destructor.h"
#include "base/thread_annotations.h"
#include "base/threading/thread.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include "base/check.h"
#include "base/command_line.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/time/time.h"
#include "components/component_updater/component_installer.h"
#include "components/component_updater/component_updater_service.h"
#include "components/component_updater/component_updater_utils.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,11 @@
#include "components/update_client/update_client_errors.h"
#include "third_party/abseil-cpp/absl/types/optional.h"

namespace android_webview {
namespace base {
class TimeTicks;
}

namespace android_webview {
using RegisterComponentsCallback =
base::RepeatingCallback<bool(const update_client::CrxComponent&)>;

Expand All @@ -34,8 +37,8 @@ class AwComponentUpdateService {
public:
static AwComponentUpdateService* GetInstance();

// Callback used for updating components, with an int that represents how many
// components were actually updated.
// Callback used for updating components, with an int that represents how
// many components were actually updated.
using UpdateCallback = base::OnceCallback<void(int)>;

void StartComponentUpdateService(UpdateCallback finished_callback);
Expand Down Expand Up @@ -80,10 +83,11 @@ class AwComponentUpdateService {
// A collection of every registered component.
base::flat_map<std::string, update_client::CrxComponent> components_;

// Maintains the order in which components have been registered. The position
// of a component id in this sequence indicates the priority of the component.
// The sooner the component gets registered, the higher its priority, and
// the closer this component is to the beginning of the vector.
// Maintains the order in which components have been registered. The
// position of a component id in this sequence indicates the priority of the
// component. The sooner the component gets registered, the higher its
// priority, and the closer this component is to the beginning of the
// vector.
std::vector<std::string> components_order_;

void RecordComponentsUpdated(UpdateCallback on_finished,
Expand Down
1 change: 1 addition & 0 deletions ash/public/cpp/holding_space/holding_space_constants.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#define ASH_PUBLIC_CPP_HOLDING_SPACE_HOLDING_SPACE_CONSTANTS_H_

#include "ash/public/cpp/app_menu_constants.h"
#include "base/time/time.h"
#include "ui/gfx/geometry/insets.h"
#include "ui/gfx/geometry/size.h"

Expand Down
4 changes: 4 additions & 0 deletions ash/public/cpp/shelf_config.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
#include "ui/display/display_observer.h"
#include "ui/gfx/animation/tween.h"

namespace base {
class TimeDelta;
}

namespace session_manager {
enum class SessionState;
} // namespace session_manager
Expand Down
5 changes: 1 addition & 4 deletions ash/public/cpp/test/test_nearby_share_delegate.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@

#include "ash/public/cpp/ash_public_export.h"
#include "ash/public/cpp/nearby_share_delegate.h"

namespace base {
class TimeTicks;
} // namespace base
#include "base/time/time.h"

namespace ash {

Expand Down
4 changes: 4 additions & 0 deletions ash/services/recording/recording_encoder_muxer.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
#include "third_party/abseil-cpp/absl/types/optional.h"
#include "ui/gfx/geometry/size.h"

namespace base {
class FilePath;
}

namespace media {
class VideoFrame;
} // namespace media
Expand Down
1 change: 1 addition & 0 deletions ash/wm/window_state.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#include "base/gtest_prod_util.h"
#include "base/macros.h"
#include "base/observer_list.h"
#include "base/time/time.h"
#include "third_party/abseil-cpp/absl/types/optional.h"
#include "ui/aura/window_observer.h"
#include "ui/base/ui_base_types.h"
Expand Down
2 changes: 2 additions & 0 deletions base/profiler/sample_metadata.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@

namespace base {

class TimeTicks;

class BASE_EXPORT SampleMetadata {
public:
// Set the metadata value associated with |name|.
Expand Down
1 change: 1 addition & 0 deletions base/test/sequenced_task_runner_test_template.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include "base/sequenced_task_runner.h"
#include "base/synchronization/condition_variable.h"
#include "base/synchronization/lock.h"
#include "base/threading/platform_thread.h"
#include "base/time/time.h"
#include "testing/gtest/include/gtest/gtest.h"

Expand Down
1 change: 1 addition & 0 deletions base/trace_event/trace_event.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include "base/atomicops.h"
#include "base/base_export.h"
#include "base/debug/debugging_buildflags.h"
#include "base/threading/platform_thread.h"
#include "base/time/time.h"
#include "base/time/time_override.h"
#include "base/trace_event/builtin_categories.h"
Expand Down
1 change: 1 addition & 0 deletions base/trace_event/trace_log.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include "base/memory/scoped_refptr.h"
#include "base/no_destructor.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/platform_thread.h"
#include "base/time/time_override.h"
#include "base/trace_event/category_registry.h"
#include "base/trace_event/memory_dump_provider.h"
Expand Down
3 changes: 3 additions & 0 deletions cc/animation/animation_timeline.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
#include "cc/animation/animation_timeline.h"

#include <algorithm>
#include <utility>
#include <vector>

#include "base/time/time.h"
#include "cc/animation/animation.h"
#include "cc/animation/animation_host.h"
#include "cc/trees/property_tree.h"
Expand Down
5 changes: 5 additions & 0 deletions cc/animation/animation_timeline.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,15 @@

#include <memory>
#include <unordered_map>
#include <vector>

#include "base/memory/ref_counted.h"
#include "cc/animation/animation_export.h"

namespace base {
class TimeTicks;
}

namespace cc {

class Animation;
Expand Down
1 change: 1 addition & 0 deletions cc/layers/heads_up_display_layer_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
#include "third_party/skia/include/core/SkFont.h"
#include "third_party/skia/include/core/SkPaint.h"
#include "third_party/skia/include/core/SkPath.h"
#include "third_party/skia/include/core/SkTextBlob.h"
#include "third_party/skia/include/core/SkTypeface.h"
#include "third_party/skia/include/gpu/GrDirectContext.h"
#include "ui/gfx/geometry/point.h"
Expand Down
1 change: 1 addition & 0 deletions cc/paint/display_item_list_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include "third_party/skia/include/core/SkBitmap.h"
#include "third_party/skia/include/core/SkColor.h"
#include "third_party/skia/include/core/SkSurface.h"
#include "third_party/skia/include/core/SkTextBlob.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/rect_conversions.h"
#include "ui/gfx/skia_util.h"
Expand Down
1 change: 1 addition & 0 deletions cc/paint/paint_op_buffer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include "third_party/skia/include/core/SkCanvas.h"
#include "third_party/skia/include/core/SkRegion.h"
#include "third_party/skia/include/core/SkSerialProcs.h"
#include "third_party/skia/include/core/SkTextBlob.h"
#include "third_party/skia/include/docs/SkPDFDocument.h"
#include "third_party/skia/include/gpu/GrRecordingContext.h"
#include "ui/gfx/skia_util.h"
Expand Down
1 change: 1 addition & 0 deletions cc/paint/paint_op_helper_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include "cc/paint/paint_canvas.h"
#include "cc/paint/paint_op_buffer.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/skia/include/core/SkTextBlob.h"

namespace cc {
namespace {
Expand Down
1 change: 1 addition & 0 deletions cc/paint/record_paint_canvas.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include "cc/paint/paint_recorder.h"
#include "cc/paint/skottie_wrapper.h"
#include "third_party/skia/include/core/SkAnnotation.h"
#include "third_party/skia/include/core/SkTextBlob.h"
#include "third_party/skia/include/utils/SkNWayCanvas.h"

namespace cc {
Expand Down
1 change: 1 addition & 0 deletions cc/paint/skia_paint_canvas.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include "cc/paint/skottie_wrapper.h"
#include "skia/ext/legacy_display_globals.h"
#include "third_party/skia/include/core/SkAnnotation.h"
#include "third_party/skia/include/core/SkTextBlob.h"
#include "third_party/skia/include/docs/SkPDFDocument.h"

namespace cc {
Expand Down
1 change: 1 addition & 0 deletions cc/test/fake_content_layer_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include <cstddef>

#include "cc/paint/paint_op_buffer.h"
#include "third_party/skia/include/core/SkTextBlob.h"
#include "ui/gfx/geometry/rect_conversions.h"
#include "ui/gfx/skia_util.h"

Expand Down
1 change: 1 addition & 0 deletions cc/trees/layer_tree_host_unittest_capture_content.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include "cc/test/fake_picture_layer.h"
#include "cc/test/layer_tree_test.h"
#include "cc/trees/transform_node.h"
#include "third_party/skia/include/core/SkTextBlob.h"

namespace cc {
namespace {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#include "chrome/browser/android/metrics/android_session_durations_service_factory.h"

#include "base/time/time.h"
#include "build/build_config.h"
#include "chrome/browser/android/metrics/android_session_durations_service.h"
#include "chrome/browser/profiles/incognito_helpers.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@
class AndroidSessionDurationsService;
class Profile;

namespace base {
class TimeDelta;
class TimeTicks;
} // namespace base

class AndroidSessionDurationsServiceFactory
: public BrowserContextKeyedServiceFactory {
public:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include "base/logging.h"
#include "base/metrics/histogram_functions.h"
#include "base/no_destructor.h"
#include "base/time/time.h"
#include "chrome/browser/ash/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.h"
#include "chrome/browser/ash/arc/instance_throttle/arc_active_window_throttle_observer.h"
#include "chrome/browser/ash/arc/instance_throttle/arc_app_launch_throttle_observer.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
#include "components/arc/arc_util.h"
#include "components/keyed_service/core/keyed_service.h"

namespace base {
class TimeDelta;
}

namespace content {
class BrowserContext;
}
Expand Down
1 change: 1 addition & 0 deletions chrome/browser/ash/crostini/crostini_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include "base/strings/strcat.h"
#include "base/strings/stringprintf.h"
#include "base/task/post_task.h"
#include "base/time/time.h"
#include "base/timer/timer.h"
#include "chrome/browser/ash/crostini/crostini_features.h"
#include "chrome/browser/ash/crostini/crostini_installer.h"
Expand Down
1 change: 1 addition & 0 deletions chrome/browser/ash/crostini/crostini_util.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ class Window;

namespace base {
class FilePath;
class TimeTicks;
} // namespace base

namespace views {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include <string>

#include "base/callback.h"
#include "base/time/time.h"
#include "chrome/browser/ash/login/screens/base_screen.h"
// TODO(https://crbug.com/1164001): move to forward declaration.
#include "chrome/browser/ui/webui/chromeos/login/gesture_navigation_screen_handler.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include <memory>
#include <string>

#include "base/files/file.h"
#include "base/memory/weak_ptr.h"
#include "base/unguessable_token.h"
#include "chromeos/components/personalization_app/mojom/personalization_app.mojom.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include <cstdint>

#include "base/bind.h"
#include "base/files/file_path.h"
#include "base/macros.h"
#include "base/strings/string_number_conversions.h"
#include "base/system/sys_info.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#include "base/logging.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "base/time/time.h"
#include "base/values.h"
#include "chromeos/system/statistics_provider.h"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include "base/location.h"
#include "base/logging.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/time/time.h"
#include "chromeos/dbus/session_manager/session_manager_client.h"

namespace policy {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"

namespace base {
class TimeDelta;
}

namespace chromeos {
class SessionManagerClient;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "base/time/time.h"
#include "chrome/browser/chromeos/printing/history/print_job_database.h"

class PrefService;
Expand Down
1 change: 1 addition & 0 deletions chrome/browser/chromeos/throttle_service.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "base/observer_list.h"
#include "base/time/time.h"
#include "chrome/browser/chromeos/throttle_observer.h"

namespace content {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,18 @@
#include <memory>

#include "build/build_config.h"
#if BUILDFLAG(IS_CHROMEOS_ASH)
#include "chrome/browser/device_identity/chromeos/device_oauth2_token_store_chromeos.h"
#else
#include "chrome/browser/device_identity/device_oauth2_token_store_desktop.h"
#endif
#include "build/chromeos_buildflags.h"
#include "chrome/browser/device_identity/device_oauth2_token_service.h"
#include "components/policy/core/common/features.h"
#include "content/public/browser/browser_thread.h"
#include "services/network/public/cpp/shared_url_loader_factory.h"

#if BUILDFLAG(IS_CHROMEOS_ASH)
#include "chrome/browser/device_identity/chromeos/device_oauth2_token_store_chromeos.h"
#else
#include "chrome/browser/device_identity/device_oauth2_token_store_desktop.h"
#endif

namespace {

static DeviceOAuth2TokenService* g_device_oauth2_token_service_ = nullptr;
Expand Down
1 change: 1 addition & 0 deletions chrome/browser/extensions/install_signer.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

#include "base/callback.h"
#include "base/macros.h"
#include "base/time/time.h"
#include "extensions/common/extension_id.h"

namespace base {
Expand Down
1 change: 1 addition & 0 deletions chrome/browser/federated_learning/floc_event_logger.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include "base/callback_forward.h"
#include "base/gtest_prod_util.h"
#include "base/memory/weak_ptr.h"
#include "base/time/time.h"
#include "components/sync/driver/sync_service_observer.h"

namespace syncer {
Expand Down
1 change: 1 addition & 0 deletions chrome/browser/media/media_engagement_session.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#define CHROME_BROWSER_MEDIA_MEDIA_ENGAGEMENT_SESSION_H_

#include "base/memory/ref_counted.h"
#include "base/time/time.h"
#include "services/metrics/public/cpp/ukm_source_id.h"
#include "url/origin.h"

Expand Down
Loading

0 comments on commit b4ee337

Please sign in to comment.