Skip to content

Commit

Permalink
Fixes bug in paint scrollbar corner
Browse files Browse the repository at this point in the history
I had thought a clip was set, but it isn't always. So, this code needs
to fill a rect just for the region passed.

BUG=333499 341787
TEST=none
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/149663006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249847 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
sky@chromium.org committed Feb 7, 2014
1 parent 12464f7 commit b5faeed
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
6 changes: 5 additions & 1 deletion ui/native_theme/native_theme_aurawin.cc
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,11 @@ void NativeThemeAuraWin::PaintScrollbarThumb(SkCanvas* sk_canvas,
void NativeThemeAuraWin::PaintScrollbarCorner(SkCanvas* canvas,
State state,
const gfx::Rect& rect) const {
canvas->drawColor(SkColorSetRGB(0xF1, 0xF1, 0xF1), SkXfermode::kSrc_Mode);
SkPaint paint;
paint.setColor(SkColorSetRGB(0xF1, 0xF1, 0xF1));
paint.setStyle(SkPaint::kFill_Style);
paint.setXfermodeMode(SkXfermode::kSrc_Mode);
canvas->drawIRect(RectToSkIRect(rect), paint);
}

NineImagePainter* NativeThemeAuraWin::GetOrCreatePainter(
Expand Down
6 changes: 5 additions & 1 deletion ui/native_theme/native_theme_base.cc
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,11 @@ void NativeThemeBase::PaintScrollbarThumb(SkCanvas* canvas,
void NativeThemeBase::PaintScrollbarCorner(SkCanvas* canvas,
State state,
const gfx::Rect& rect) const {
canvas->drawColor(SK_ColorWHITE, SkXfermode::kSrc_Mode);
SkPaint paint;
paint.setColor(SK_ColorWHITE);
paint.setStyle(SkPaint::kFill_Style);
paint.setXfermodeMode(SkXfermode::kSrc_Mode);
canvas->drawIRect(RectToSkIRect(rect), paint);
}

void NativeThemeBase::PaintCheckbox(SkCanvas* canvas,
Expand Down

0 comments on commit b5faeed

Please sign in to comment.