forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add new histograms to report errors initializing SQLite database.
This CL adds two new histograms that report more details on failed SQLitePersistentStore DB initialization. These new metrics are reported for both instantiations, ReportingAndNEL and Cookie. The first, ErrorInitializeDB is the SQLite error code upon initialization failure and is reported on all platforms. The second, WinGetLastErrorInitializeDB is the ::GetLastError returned on the DB thread after attempting to load the database, and is only reported on Windows. A test is added to verify this behavior, along with verifying that the new histograms are only emitted in the failure case. UmaHistogramSqliteResult is updated to take a const std::string ref to match the underlying UMA functions being called. BUG=1429117 Change-Id: I1bc2c898b005232305cebfde80a0dd8d4cfafd68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608890 Reviewed-by: Austin Sullivan <asully@chromium.org> Reviewed-by: Chris Fredrickson <cfredric@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1157192}
- Loading branch information
1 parent
c21c033
commit b60653c
Showing
6 changed files
with
124 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters