Reland "win: Always set strip_absolute_paths_from_debug_symbols, inde…

…pendent of goma."

This reverts commit f61b660.

Reason for revert: After today's clang roll, this should now work better.

Original change's description:
> Revert "win: Always set strip_absolute_paths_from_debug_symbols, independent of goma."
>
> This reverts commit 2bf513a.
>
> Reason for revert: Breaks the symbol step for the official build, see crbug.com/911873
>
> Original change's description:
> > win: Always set strip_absolute_paths_from_debug_symbols, independent of goma.
> >
> > There's no downside of doing this on Windows and it makes the build
> > deterministic, so always enable it.
> >
> > Bug: 330260
> > Change-Id: I0e86a2ae5864af2fb4e1716cff1718c9606ab42f
> > Reviewed-on: https://chromium-review.googlesource.com/c/1358700
> > Reviewed-by: Scott Graham <scottmg@chromium.org>
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#613200}
>
> TBR=thakis@chromium.org,hans@chromium.org,scottmg@chromium.org,tikuta@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 330260
> Change-Id: I4a80dc0d3ce0a5125aa94b1367a11e66aefc1ea8
> Reviewed-on: https://chromium-review.googlesource.com/c/1362492
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#613838}

Bug: 330260, 929108
Change-Id: I8175162afcbab9097cbfca6564edef3e95d10bd5
Reviewed-on: https://chromium-review.googlesource.com/c/1456294
Reviewed-by: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630283}

build/config/compiler/BUILD.gn

@@ -92,13 +92,15 @@ declare_args() {
   # the needed gcov profiling data.
   auto_profile_path = ""
 
-  # Optimize symbol files for maximizing goma cache hit rate. This is on by
-  # default for Android, and when goma is enabled on Linux and Windows.
-  # But setting this to true may make it harder to debug binaries on Linux.
-  # See below reference for detail.
+  # Use relative paths for debug info. This is important to make the build
+  # results independent of the checkout and build directory names, which
+  # in turn is important for goma compile hit rate.
+  # Setting this to true may make it harder to debug binaries on Linux, see
   # https://chromium.googlesource.com/chromium/src/+/master/docs/linux_debugging.md#Source-level-debug-with-fdebug_compilation_dir
+  # So only enable this on linux if use_goma.  Elsewhere, there are no
+  # drawbacks to using it, so always enable it there.
   strip_absolute_paths_from_debug_symbols =
-      is_android || is_nacl || (use_goma && (is_linux || (is_win && use_lld)))
+      is_android || is_nacl || (is_win && use_lld) || (use_goma && is_linux)
 
   # Allow projects that wish to stay on C++11 to override Chromium's default.
   use_cxx11 = false