Skip to content

Commit

Permalink
[Android] Disable flaky FirstRunActivitySigninAndSyncTest tests
Browse files Browse the repository at this point in the history
The test suite is generally flaky and in particular on Android Nougat.

Bug: 1459076
Change-Id: Ia1def8c2f9a3a2f0937c3e3af893b9890ce3deaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4754739
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1180611}
  • Loading branch information
tommynyquist authored and Chromium LUCI CQ committed Aug 8, 2023
1 parent 2d09c83 commit b8ff1d3
Showing 1 changed file with 12 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import android.content.Context;
import android.content.Intent;
import android.net.Uri;
import android.os.Build;
import android.text.Spanned;
import android.text.style.ClickableSpan;
import android.view.View;
Expand All @@ -49,6 +50,7 @@
import org.chromium.base.test.util.ApplicationTestUtils;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.CriteriaHelper;
import org.chromium.base.test.util.DisableIf;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.DoNotBatch;
import org.chromium.base.test.util.Matchers;
Expand Down Expand Up @@ -120,7 +122,10 @@ public void setUp() {

@Test
@MediumTest
public void dismissButtonClickSkipsSyncConsentPageWhenNoAccountsAreOnDevice() {
@DisableIf.Build(sdk_is_less_than = Build.VERSION_CODES.O,
message = "This test is disabled on Android N because of https://crbug.com/1459076")
public void
dismissButtonClickSkipsSyncConsentPageWhenNoAccountsAreOnDevice() {
launchFirstRunActivityAndWaitForNativeInitialization();
onView(withId(R.id.signin_fre_selected_account)).check(matches(not(isDisplayed())));

Expand All @@ -131,7 +136,10 @@ public void dismissButtonClickSkipsSyncConsentPageWhenNoAccountsAreOnDevice() {

@Test
@MediumTest
public void dismissButtonClickSkipsSyncConsentPageWhenOneAccountIsOnDevice() {
@DisableIf.Build(sdk_is_less_than = Build.VERSION_CODES.O,
message = "This test is disabled on Android N because of https://crbug.com/1459076")
public void
dismissButtonClickSkipsSyncConsentPageWhenOneAccountIsOnDevice() {
mAccountManagerTestRule.addAccount(TEST_EMAIL);
launchFirstRunActivityAndWaitForNativeInitialization();
onView(withId(R.id.signin_fre_selected_account)).check(matches(isDisplayed()));
Expand Down Expand Up @@ -280,6 +288,7 @@ public void acceptingSyncEndsFreAndEnablesSync() {
@Test
@MediumTest
@EnableFeatures({ChromeFeatureList.TANGIBLE_SYNC})
@DisabledTest(message = "https://crbug.com/1459076")
public void acceptingSyncEndsFreAndEnablesSync_tangibleSyncEnabled() {
when(mExternalAuthUtilsMock.canUseGooglePlayServices(any())).thenReturn(true);
mAccountManagerTestRule.addAccount(TEST_EMAIL);
Expand Down Expand Up @@ -403,6 +412,7 @@ public void refusingSyncForChildAccountEndsFreAndDoesNotEnableSync() {
// ChildAccountStatusSupplier uses AppRestrictions to quickly detect non-supervised cases,
// adding at least one policy via AppRestrictions prevents that.
@Policies.Add(@Policies.Item(key = "ForceSafeSearch", string = "true"))
@DisabledTest(message = "https://crbug.com/1459076")
public void clickingSettingsThenCancelForChildAccountDoesNotEnableSync() {
when(mExternalAuthUtilsMock.canUseGooglePlayServices(any())).thenReturn(true);
mAccountManagerTestRule.addAccount(CHILD_EMAIL);
Expand Down

0 comments on commit b8ff1d3

Please sign in to comment.