Skip to content

Commit

Permalink
[CrOS Settings] Fix navigation for storage and language.
Browse files Browse the repository at this point in the history
Similar to https://codereview.chromium.org/2713553004.

Change-Id: I584c863dbf830402f0b4500aef5b50c552653fa4
Bug: 921440
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656067
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668578}
  • Loading branch information
Regan Hsu authored and Commit Bot committed Jun 12, 2019
1 parent e1834b9 commit bca679c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
4 changes: 3 additions & 1 deletion chrome/browser/resources/settings/device_page/keyboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,9 @@ Polymer({
},

onShowLanguageInputTap_: function() {
settings.navigateTo(settings.routes.LANGUAGES);
settings.navigateTo(
settings.routes.LANGUAGES,
/* dynamicParams */ null, /* removeSearch */ true);
},

getExternalMetaKeyLabel_: function(hasInternalKeyboard) {
Expand Down
12 changes: 9 additions & 3 deletions chrome/browser/resources/settings/device_page/storage.js
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,9 @@ Polymer({
* @private
*/
onBrowsingDataTap_: function() {
settings.navigateTo(settings.routes.CLEAR_BROWSER_DATA);
settings.navigateTo(
settings.routes.CLEAR_BROWSER_DATA,
/* dynamicParams */ null, /* removeSearch */ true);
},

/**
Expand All @@ -178,15 +180,19 @@ Polymer({
* @private
*/
onCrostiniTap_: function() {
settings.navigateTo(settings.routes.CROSTINI_DETAILS);
settings.navigateTo(
settings.routes.CROSTINI_DETAILS, /* dynamicParams */ null,
/* removeSearch */ true);
},

/**
* Handler for tapping the "Other users" item.
* @private
*/
onOtherUsersTap_: function() {
settings.navigateTo(settings.routes.ACCOUNTS);
settings.navigateTo(
settings.routes.ACCOUNTS,
/* dynamicParams */ null, /* removeSearch */ true);
},

/**
Expand Down

0 comments on commit bca679c

Please sign in to comment.