Skip to content

Commit

Permalink
Enable ProcessUtilTest.LaunchWithHandleTransfer on Fuchsia
Browse files Browse the repository at this point in the history
VM performance was improved significantly with TSC clock, so the test
is not expected to timeout anymore.

Bug: 793412
Change-Id: I8a4cd1ddd35a364e490252d02ccd59946a7600fa
Reviewed-on: https://chromium-review.googlesource.com/1045612
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556499}
  • Loading branch information
SergeyUlanov authored and Commit Bot committed May 7, 2018
1 parent 794e095 commit bce3e02
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions base/process/process_util_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -875,9 +875,8 @@ TEST_F(ProcessUtilTest, FDRemappingIncludesStdio) {
EXPECT_EQ(0, exit_code);
}

// TODO(https://crbug.com/793412): Disable on Debug/component builds due to
// process launch taking too long and triggering timeouts.
#if defined(OS_FUCHSIA) && defined(NDEBUG)
#if defined(OS_FUCHSIA)

const uint16_t kStartupHandleId = 43;
MULTIPROCESS_TEST_MAIN(ProcessUtilsVerifyHandle) {
zx_handle_t handle =
Expand Down Expand Up @@ -932,7 +931,8 @@ TEST_F(ProcessUtilTest, LaunchWithHandleTransfer) {
&exit_code));
EXPECT_EQ(0, exit_code);
}
#endif // defined(OS_FUCHSIA) && defined(NDEBUG)

#endif // defined(OS_FUCHSIA)

namespace {

Expand Down

0 comments on commit bce3e02

Please sign in to comment.