forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[base] Remove const iterator member functions from span
This change implements the resolution of LWG issue 3320 by removing the members cbegin(), cend(), crbegin() and crend() from base::span. This was done because std::cbegin(std::span<T>()) and std::span<T>().cbegin() returned different results if T was non-const. Note that the nested const_iterator type is not yet removed from base::span, as this breaks using it in gMock matchers like ElementsAre. This will be addressed once gMock no longer requires the presence of this nested type. References: * https://wg21.link/LWG3320 * cplusplus/draft@6faa9c TBR=dcheng Bug: 828324 Change-Id: I21f8ffaa0c7183d6e63a087b73f271b677d13f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086231 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#747216}
- Loading branch information
Showing
7 changed files
with
27 additions
and
53 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters