Skip to content

Commit

Permalink
Add a gin/public directory
Browse files Browse the repository at this point in the history
When we start using gin from other projects but mojo, we want to be
extra careful what we include. Therefore, we introduce a public/
directories with headers that are ok to be included from gin-embedders.

As a start, we move wrapper_info.h into public/.

BUG=317398
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/69293015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236114 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
jochen@chromium.org committed Nov 20, 2013
1 parent b873bc8 commit c07006b
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion gin/gin.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
'try_catch.cc',
'try_catch.h',
'wrapper_info.cc',
'wrapper_info.h',
'public/wrapper_info.h',
],
},
{
Expand Down
2 changes: 1 addition & 1 deletion gin/modules/console.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "gin/arguments.h"
#include "gin/converter.h"
#include "gin/per_isolate_data.h"
#include "gin/wrapper_info.h"
#include "gin/public/wrapper_info.h"

using v8::ObjectTemplate;

Expand Down
2 changes: 1 addition & 1 deletion gin/modules/module_registry.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#include "gin/arguments.h"
#include "gin/converter.h"
#include "gin/per_isolate_data.h"
#include "gin/wrapper_info.h"
#include "gin/public/wrapper_info.h"

using v8::Context;
using v8::External;
Expand Down
2 changes: 1 addition & 1 deletion gin/per_context_data.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#include "gin/per_context_data.h"

#include "base/logging.h"
#include "gin/wrapper_info.h"
#include "gin/public/wrapper_info.h"

namespace gin {

Expand Down
2 changes: 1 addition & 1 deletion gin/per_isolate_data.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <map>

#include "base/basictypes.h"
#include "gin/wrapper_info.h"
#include "gin/public/wrapper_info.h"
#include "v8/include/v8.h"

namespace gin {
Expand Down
6 changes: 3 additions & 3 deletions gin/wrapper_info.h → gin/public/wrapper_info.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef GIN_WRAPPER_INFO_H_
#define GIN_WRAPPER_INFO_H_
#ifndef GIN_PUBLIC_WRAPPER_INFO_H_
#define GIN_PUBLIC_WRAPPER_INFO_H_

#include "v8/include/v8.h"

Expand All @@ -22,4 +22,4 @@ struct WrapperInfo {

} // namespace gin

#endif // GIN_WRAPPER_INFO_H_
#endif // GIN_PUBLIC_WRAPPER_INFO_H_
2 changes: 1 addition & 1 deletion gin/test/gtest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#include "gin/arguments.h"
#include "gin/converter.h"
#include "gin/per_isolate_data.h"
#include "gin/wrapper_info.h"
#include "gin/public/wrapper_info.h"
#include "testing/gtest/include/gtest/gtest.h"

using v8::ObjectTemplate;
Expand Down
2 changes: 1 addition & 1 deletion gin/wrapper_info.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "gin/wrapper_info.h"
#include "gin/public/wrapper_info.h"

namespace gin {

Expand Down
2 changes: 1 addition & 1 deletion mojo/public/bindings/js/core.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include "gin/converter.h"
#include "gin/dictionary.h"
#include "gin/per_isolate_data.h"
#include "gin/wrapper_info.h"
#include "gin/public/wrapper_info.h"
#include "mojo/public/bindings/js/handle.h"

namespace mojo {
Expand Down

0 comments on commit c07006b

Please sign in to comment.