Skip to content

Commit

Permalink
Move components/signin internal deps to subdirs
Browse files Browse the repository at this point in the history
This CL introduces explicit dependencies to components/signin/public
subdirs in //componenents/signin code.

Bug: 970268
Change-Id: I65023a68b702097edde2021e7defe0c517559fe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757830
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#694164}
  • Loading branch information
hferreiro authored and Commit Bot committed Sep 6, 2019
1 parent 95aefc4 commit c14524a
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 6 deletions.
1 change: 0 additions & 1 deletion components/signin/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ include_rules = [
# Subdirectories of //components/signin must explicitly allow deps on each
# other based on the conceptual deps structure.
"-components/signin",
"+components/signin/public",
"+components/user_manager",
"+components/webdata/common",
"+crypto",
Expand Down
2 changes: 2 additions & 0 deletions components/signin/core/browser/DEPS
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
include_rules = [
"+components/metrics",
"+components/signin/public/base",
"+components/signin/public/identity_manager",
]
3 changes: 3 additions & 0 deletions components/signin/internal/identity_manager/DEPS
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
include_rules = [
"+chromeos/constants/chromeos_features.h",
"+components/signin/public/base",
"+components/signin/public/identity_manager",
"+components/signin/public/webdata",
"+mojo/public",
]

Expand Down
5 changes: 0 additions & 5 deletions components/signin/ios/DEPS

This file was deleted.

8 changes: 8 additions & 0 deletions components/signin/ios/browser/DEPS
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
include_rules = [
"+components/signin/public/base",
"+components/signin/public/identity_manager",
"+ios/web/common",
"+ios/web/public",
"+third_party/ocmock",
]

specific_include_rules = {
"account_consistency_service.mm": [
"+components/signin/core/browser/account_reconcilor.h",
Expand Down
5 changes: 5 additions & 0 deletions components/signin/public/DEPS
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
include_rules = [
# Subdirectories of //components/signin/public must explicitly allow deps on
# each other based on the conceptual deps structure.
"-components/signin/public"
]
1 change: 1 addition & 0 deletions components/signin/public/identity_manager/DEPS
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
include_rules = [
"+components/signin/internal",
"+components/signin/public",
]

0 comments on commit c14524a

Please sign in to comment.