forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix crash when HTMLPreloadScanner encounters atypical picture children
When a picture element was opened but not closed, internal tags would get preloaded as image_set typed resources, which shouldn't happen when the loaded resources are not images. This CL fixes that by terminating picture-like processing as soon as an atypical tag is encountered inside `<picture>`. That may reduce preloading for invalid `<picture>` tags, but that is most-probably fine. Bug: 961151 Change-Id: I392b87e51100175b38461d47f7677c840448c78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626590 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#662674}
- Loading branch information
Yoav Weiss
authored and
Commit Bot
committed
May 23, 2019
1 parent
1289dbf
commit c1f636e
Showing
3 changed files
with
20 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters