Skip to content

Commit

Permalink
Remove spurious STL header includes from ppapi
Browse files Browse the repository at this point in the history
Remove a bunch of unused includes. Then add includes as needed to fix
the build.

Change-Id: Id30743cfb6db3473b30c5357f359a6e92f687057
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582744
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1156401}
  • Loading branch information
leizleiz authored and Chromium LUCI CQ committed Jun 12, 2023
1 parent 209393c commit c282611
Show file tree
Hide file tree
Showing 19 changed files with 9 additions and 22 deletions.
2 changes: 2 additions & 0 deletions ppapi/cpp/file_ref.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
#ifndef PPAPI_CPP_FILE_REF_H_
#define PPAPI_CPP_FILE_REF_H_

#include <vector>

#include "ppapi/c/pp_file_info.h"
#include "ppapi/c/pp_stdint.h"
#include "ppapi/c/ppb_file_ref.h"
Expand Down
2 changes: 1 addition & 1 deletion ppapi/cpp/input_event.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#include <stdint.h>

#include <string>
#include <utility>
#include <vector>

#include "ppapi/c/ppb_input_event.h"
Expand Down
3 changes: 3 additions & 0 deletions ppapi/cpp/private/var_private.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@

#include <stdint.h>

#include <string>
#include <vector>

#include "ppapi/cpp/var.h"

namespace pp {
Expand Down
1 change: 0 additions & 1 deletion ppapi/cpp/var.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <stdint.h>

#include <string>
#include <vector>

#include "ppapi/c/pp_var.h"
#include "ppapi/cpp/pass_ref.h"
Expand Down
4 changes: 1 addition & 3 deletions ppapi/proxy/dispatcher.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
#ifndef PPAPI_PROXY_DISPATCHER_H_
#define PPAPI_PROXY_DISPATCHER_H_

#include <set>
#include <string>
#include <vector>
#include <memory>

#include "base/compiler_specific.h"
#include "base/memory/scoped_refptr.h"
Expand Down
1 change: 0 additions & 1 deletion ppapi/proxy/file_io_resource.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <stdint.h>

#include <memory>
#include <string>

#include "base/files/file.h"
#include "base/memory/ref_counted.h"
Expand Down
2 changes: 1 addition & 1 deletion ppapi/proxy/file_ref_resource.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#include <stdint.h>

#include <string>
#include <vector>

#include "ppapi/c/pp_instance.h"
#include "ppapi/c/pp_resource.h"
Expand Down
1 change: 0 additions & 1 deletion ppapi/proxy/plugin_var_tracker.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#define PPAPI_PROXY_PLUGIN_VAR_TRACKER_H_

#include <map>
#include <string>

#include "base/compiler_specific.h"
#include "base/memory/scoped_refptr.h"
Expand Down
2 changes: 0 additions & 2 deletions ppapi/proxy/ppb_graphics_3d_proxy.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

#include <stdint.h>

#include <vector>

#include "gpu/command_buffer/common/command_buffer.h"
#include "gpu/command_buffer/common/command_buffer_id.h"
#include "ppapi/c/pp_graphics_3d.h"
Expand Down
1 change: 0 additions & 1 deletion ppapi/proxy/ppb_instance_proxy.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <stdint.h>

#include <string>
#include <vector>

#include "build/build_config.h"
#include "ppapi/c/pp_instance.h"
Expand Down
1 change: 0 additions & 1 deletion ppapi/proxy/ppp_printing_proxy.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

#include <stdint.h>

#include <string>
#include <vector>

#include "ppapi/c/dev/ppp_printing_dev.h"
Expand Down
3 changes: 1 addition & 2 deletions ppapi/proxy/serialized_handle.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@

#include <stdint.h>

#include <string>
#include <vector>
#include <utility>

#include "base/atomicops.h"
#include "base/check_op.h"
Expand Down
1 change: 0 additions & 1 deletion ppapi/shared_impl/ppb_video_decoder_shared.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <stdint.h>

#include <map>
#include <vector>

#include "base/compiler_specific.h"
#include "ppapi/c/dev/ppb_video_decoder_dev.h"
Expand Down
2 changes: 0 additions & 2 deletions ppapi/shared_impl/tracked_callback.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@

#include <stdint.h>

#include <map>
#include <memory>
#include <set>

#include "base/functional/callback.h"
#include "base/memory/ref_counted.h"
Expand Down
1 change: 0 additions & 1 deletion ppapi/tests/test_crypto.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#define PPAPI_TESTS_TEST_CRYPTO_H_

#include <string>
#include <vector>

#include "ppapi/c/dev/ppb_crypto_dev.h"
#include "ppapi/tests/test_case.h"
Expand Down
1 change: 0 additions & 1 deletion ppapi/tests/test_cursor_control.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#define PPAPI_TESTS_TEST_CURSOR_CONTROL_H_

#include <string>
#include <vector>

#include "ppapi/c/dev/ppb_cursor_control_dev.h"
#include "ppapi/tests/test_case.h"
Expand Down
1 change: 0 additions & 1 deletion ppapi/tests/test_input_event.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <stdint.h>

#include <string>
#include <vector>

#include "ppapi/c/ppb_input_event.h"
#include "ppapi/c/private/ppb_testing_private.h"
Expand Down
1 change: 0 additions & 1 deletion ppapi/tests/test_message_handler.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#define PPAPI_TESTS_TEST_MESSAGE_HANDLER_H_

#include <string>
#include <vector>

#include "ppapi/c/ppb_messaging.h"
#include "ppapi/tests/test_case.h"
Expand Down
1 change: 0 additions & 1 deletion ppapi/thunk/ppb_video_capture_api.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <stdint.h>

#include <string>
#include <vector>

#include "base/memory/scoped_refptr.h"
#include "ppapi/c/dev/ppb_video_capture_dev.h"
Expand Down

0 comments on commit c282611

Please sign in to comment.