Skip to content

Commit

Permalink
CrOS Shelf: Add an 'UpdateLayout' call that was left out previously
Browse files Browse the repository at this point in the history
The idea behind some of the recent refactorings is to split the logic
for calculating target bounds and upating the layout to each shelf
component instead of doing everything in the shelf layout manager.

Previously, some (limited, soon more) work was delegated to the
shelf widget's |UpdateLayout| method, but calling that method from
the "central" place in the shelf layout manager was omitted. This change
reinstates that call.

Bug: 1051824, 1050383
Change-Id: Ibcf3bfd26210278ec464f186ae6a0a958f03d644
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055392
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741176}
  • Loading branch information
Manu Cornet authored and Commit Bot committed Feb 13, 2020
1 parent 554a259 commit c34422a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ash/shelf/shelf_layout_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1507,6 +1507,7 @@ void ShelfLayoutManager::UpdateBoundsAndOpacity(bool animate) {
gfx::Tween::EASE_OUT);
shelf_widget_->GetLayer()->SetTransform(gfx::Transform());

shelf_->shelf_widget()->UpdateLayout(animate);
hotseat_widget->UpdateLayout(animate);

// Having a window which is visible but does not have an opacity is an
Expand Down

0 comments on commit c34422a

Please sign in to comment.