Skip to content

Commit

Permalink
Remove old wtf/ directory.
Browse files Browse the repository at this point in the history
The removal comes with various fixups in several places:

(1) Various BUILD.gn files are updated so they point to the new location;
(2) Code generator templates in Source/build are fixed; and
(3) Other random references to old wtf/ are fixed.

BUG=691465
R=haraken@chromium.org,thakis@chromium.org,yzshen@chromium.org,dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2822953002
Cr-Commit-Position: refs/heads/master@{#464941}
  • Loading branch information
yutak authored and Commit bot committed Apr 17, 2017
1 parent 9bb7188 commit c36ab84
Show file tree
Hide file tree
Showing 192 changed files with 66 additions and 1,842 deletions.
2 changes: 1 addition & 1 deletion mojo/public/cpp/bindings/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ if (!is_ios) {

public_deps = [
":bindings",
"//third_party/WebKit/Source/wtf",
"//third_party/WebKit/Source/platform/wtf",
]

public_configs = [ "//third_party/WebKit/Source:config" ]
Expand Down
5 changes: 0 additions & 5 deletions third_party/WebKit/Source/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,6 @@ config("blink_pch") {

config("config") {
include_dirs = [
# crbug.com/691465: Temporary solution to fix an issue related to MSVC-
# specific #include search order. This essentially lets
# #include "wtf/Foo.h" actually include "platform/wtf/Foo.h". This is okay
# because these files are equivalent if both exist.
"platform",
".",
"..",
"$root_gen_dir/blink",
Expand Down
2 changes: 1 addition & 1 deletion third_party/WebKit/Source/bindings/core/v8/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ source_set("testing") {
deps = [
":bindings_core_impl_generated",
"//skia",
"//third_party/WebKit/Source/wtf",
"//third_party/WebKit/Source/platform/wtf",
"//v8",
]
}
Expand Down
2 changes: 1 addition & 1 deletion third_party/WebKit/Source/bindings/modules/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ source_set("generated") {
":event_modules_names",
":event_target_modules_names",
"//third_party/WebKit/Source/core",
"//third_party/WebKit/Source/wtf",
"//third_party/WebKit/Source/platform/wtf",
"//v8",
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include "modules/fetch/BodyStreamBuffer.h"
#include "modules/fetch/FetchDataLoader.h"
#include "platform/heap/Handle.h"
#include "wtf/RefPtr.h"
#include "platform/wtf/RefPtr.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
#define WasmResponseExtensions_h

#include "modules/ModulesExport.h"
#include "platform/wtf/Allocator.h"
#include "v8/include/v8.h"
#include "wtf/Allocator.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#define %(class_name)s_h
#include "core/CoreExport.h"
#include "wtf/Assertions.h"
#include "platform/wtf/Assertions.h"
#include <stddef.h>
namespace WTF {
Expand Down Expand Up @@ -85,9 +85,9 @@ class String;
#include "core/css/HashTools.h"
#include <string.h>
#include "wtf/ASCIICType.h"
#include "wtf/text/AtomicString.h"
#include "wtf/text/WTFString.h"
#include "platform/wtf/ASCIICType.h"
#include "platform/wtf/text/AtomicString.h"
#include "platform/wtf/text/WTFString.h"
#ifdef _MSC_VER
// Disable the warnings from casting a 64-bit pointer to 32-bit long
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#include "core/css/CSSPropertyIDTemplates.h"
#include "core/css/cssom/CSSKeywordValue.h"
#include "wtf/HashMap.h"
#include "platform/wtf/HashMap.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#define CSSPropertyAPI_h

#include "core/CSSPropertyNames.h"
#include "wtf/Allocator.h"
#include "platform/wtf/Allocator.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{license()}}

#include "core/ComputedStyleBase.h"
#include "wtf/SizeAssertions.h"
#include "platform/wtf/SizeAssertions.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include "core/dom/Document.h"
#include "core/frame/Settings.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "wtf/HashMap.h"
#include "platform/wtf/HashMap.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

#include "core/dom/Document.h"
#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
#include "wtf/PassRefPtr.h"
#include "platform/wtf/Forward.h"
#include "platform/wtf/PassRefPtr.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#define {{namespace}}ElementLookupTrie_h

#include "core/CoreExport.h"
#include "wtf/text/StringImpl.h"
#include "platform/wtf/text/StringImpl.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

#include "core/dom/Document.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "wtf/HashMap.h"
#include "platform/wtf/HashMap.h"

namespace blink {
{% if namespace == "HTML" %}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "platform/heap/Handle.h"
#include "wtf/PassRefPtr.h"
#include "wtf/RefPtr.h"
#include "wtf/RefCounted.h"
#include "platform/wtf/PassRefPtr.h"
#include "platform/wtf/RefPtr.h"
#include "platform/wtf/RefCounted.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@

#include "bindings/core/v8/ScriptWrappable.h"
#include "platform/heap/Handle.h"
#include "wtf/PassRefPtr.h"
#include "wtf/RefCounted.h"
#include "wtf/text/WTFString.h"
#include "platform/wtf/PassRefPtr.h"
#include "platform/wtf/RefCounted.h"
#include "platform/wtf/text/WTFString.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

#include "{{namespace}}{{suffix}}Names.h"

#include "wtf/StdLibExtras.h"
#include "platform/wtf/StdLibExtras.h"

// Generated from:
{% for entry in in_files|sort %}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
{% if suffix %}
#include "core/{{namespace}}Names.h"
{% else %}
#include "wtf/text/AtomicString.h"
#include "platform/wtf/text/AtomicString.h"
{% endif %}
{% if export == 'CORE_EXPORT' %}
#include "core/CoreExport.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@

#include "{{namespace}}Names.h"

#include "wtf/PtrUtil.h"
#include "wtf/StaticConstructors.h"
#include "wtf/StdLibExtras.h"
#include "platform/wtf/PtrUtil.h"
#include "platform/wtf/StaticConstructors.h"
#include "platform/wtf/StdLibExtras.h"
#include <memory>

namespace blink {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#define OriginTrials_h

#include "core/CoreExport.h"
#include "wtf/text/WTFString.h"
#include "platform/wtf/text/WTFString.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

#include "platform/RuntimeEnabledFeatures.h"

#include "wtf/Assertions.h"
#include "wtf/text/WTFString.h"
#include "platform/wtf/Assertions.h"
#include "platform/wtf/text/WTFString.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
#include <string>

#include "platform/PlatformExport.h"
#include "wtf/Allocator.h"
#include "wtf/Forward.h"
#include "wtf/build_config.h"
#include "platform/wtf/Allocator.h"
#include "platform/wtf/Forward.h"
#include "platform/wtf/build_config.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
#include "StylePropertyShorthand.h"

#include "platform/RuntimeEnabledFeatures.h"
#include "wtf/HashMap.h"
#include "wtf/StdLibExtras.h"
#include "platform/wtf/HashMap.h"
#include "platform/wtf/StdLibExtras.h"

namespace blink {
{% for property_id, property in properties.items() %}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#define StylePropertyShorthand_h

#include "CSSPropertyNames.h"
#include "wtf/Vector.h"
#include "platform/wtf/Vector.h"

namespace blink {

Expand Down
8 changes: 4 additions & 4 deletions third_party/WebKit/Source/core/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ source_set("generated") {
"//third_party/WebKit/Source/bindings/modules:bindings_modules_generated",
"//third_party/WebKit/Source/bindings/modules/v8:bindings_modules_generated",
"//third_party/WebKit/Source/platform:make_platform_generated",
"//third_party/WebKit/Source/wtf",
"//third_party/WebKit/Source/platform/wtf",
"//url",
"//v8",
]
Expand All @@ -106,7 +106,7 @@ source_set("prerequisites") {
"//skia",
"//third_party/WebKit/Source/core/inspector:generated",
"//third_party/WebKit/Source/core/probe:generated",
"//third_party/WebKit/Source/wtf",
"//third_party/WebKit/Source/platform/wtf",
"//third_party/angle:translator",
"//third_party/iccjpeg",
"//third_party/icu",
Expand Down Expand Up @@ -166,7 +166,7 @@ component("core") {
":core_generated",
"//skia",
"//third_party/WebKit/Source/platform",
"//third_party/WebKit/Source/wtf",
"//third_party/WebKit/Source/platform/wtf",
"//url",
"//v8",
]
Expand Down Expand Up @@ -1067,7 +1067,7 @@ target(core_link_small_target_type, "core_generated") {
"//third_party/WebKit/Source/bindings/modules:bindings_modules_generated",
"//third_party/WebKit/Source/bindings/modules/v8:bindings_modules_generated",
"//third_party/WebKit/Source/platform:make_platform_generated",
"//third_party/WebKit/Source/wtf",
"//third_party/WebKit/Source/platform/wtf",
"//url",
"//v8",
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#include "core/dom/ExceptionCode.h"
#include "platform/geometry/IntRect.h"
#include "platform/geometry/IntSize.h"
#include "third_party/WebKit/Source/wtf/Optional.h"
#include "platform/wtf/Optional.h"

namespace blink {

Expand Down
2 changes: 1 addition & 1 deletion third_party/WebKit/Source/core/inspector/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ source_set("generated") {
"//third_party/WebKit/Source/bindings/core/v8:bindings_core_v8_generated",
"//third_party/WebKit/Source/core:all_generators",
"//third_party/WebKit/Source/platform:make_platform_generated",
"//third_party/WebKit/Source/wtf",
"//third_party/WebKit/Source/platform/wtf",
"//v8",
]
}
Expand Down
2 changes: 1 addition & 1 deletion third_party/WebKit/Source/core/probe/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ source_set("generated") {
deps = [
":instrumentation_probes",
"//skia",
"//third_party/WebKit/Source/wtf",
"//third_party/WebKit/Source/platform/wtf",
"//v8",
]
}
2 changes: 1 addition & 1 deletion third_party/WebKit/Source/modules/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ source_set("unit_tests") {
"//testing/gmock",
"//testing/gtest",
"//third_party/WebKit/Source/core",
"//third_party/WebKit/Source/wtf",
"//third_party/WebKit/Source/platform/wtf",
"//v8",
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
#include "modules/EventModules.h"
#include "modules/geolocation/Coordinates.h"
#include "platform/heap/Handle.h"
#include "wtf/Assertions.h"
#include "platform/wtf/Assertions.h"

namespace blink {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
#include "core/dom/DOMArrayBuffer.h"
#include "core/dom/ExceptionCode.h"
#include "modules/push_messaging/PushSubscriptionOptionsInit.h"
#include "platform/wtf/ASCIICType.h"
#include "platform/wtf/Assertions.h"
#include "platform/wtf/text/WTFString.h"
#include "public/platform/WebString.h"
#include "public/platform/modules/push_messaging/WebPushSubscriptionOptions.h"
#include "third_party/WebKit/Source/wtf/ASCIICType.h"

namespace blink {
namespace {
Expand Down
Loading

0 comments on commit c36ab84

Please sign in to comment.