Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Reland "Reland "Enable extracting unwind table on official bu…
…ilds without channel""" This reverts commit 579e583. Reason for revert: monochrome_apk_checker.py needs to be updated. crbug/827937 Original change's description: > Reland "Reland "Enable extracting unwind table on official builds without channel"" > > This reverts commit 2298aca. > > Reason for revert: Remove changes made in monochrome since apk merge script needs to > be updated first. > > Original change's description: > > Revert "Reland "Enable extracting unwind table on official builds without channel"" > > > > This reverts commit 0db71a0. > > > > Reason for revert: Monochrome apk merge is failing because the unwind > > file for both apk has the same name. > > > > Original change's description: > > > Reland "Enable extracting unwind table on official builds without channel" > > > > > > This reverts commit a2474b6. > > > > > > Reason for revert: The failure was due to parent CL getting reverted > > > Relanded parent in: https://chromium-review.googlesource.com/c/chromium/src/+/984452 > > > > > > Original change's description: > > > > Revert "Enable extracting unwind table on official builds without channel" > > > > > > > > This reverts commit eb07cea. > > > > > > > > Reason for revert: Windows tryjobs are failing. > > > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin-msvc-rel%2F81420%2F%2B%2Frecipes%2Fsteps%2Fanalyze%2F0%2Fstdout for an example. > > > > > > > > ERROR at //base/BUILD.gn:1802:33: Undefined identifier in string expansion. > > > > "CAN_UNWIND_WITH_CFI_TABLE=$can_unwind_with_cfi_table", > > > > ^------------------------ > > > > "can_unwind_with_cfi_table" is not currently in scope. > > > > See //BUILD.gn:65:5: which caused the file to be included. > > > > "//base:base_perftests", > > > > ^---------------------- > > > > GN gen failed: 1 > > > > > > > > Original change's description: > > > > > Enable extracting unwind table on official builds without channel > > > > > > > > > > This CL enables extraction of unwind tables for chrome when > > > > > is_official_build is set to true and when android_channel is not set to > > > > > a release channel. This affects build time only on official builds. > > > > > Also, Set legacy heap profiler to use unwinder for profiling. > > > > > > > > > > TBR=dpranke@chromium.org > > > > > BUG=819888 > > > > > > > > > > Change-Id: If9732b5ac1f9dff49c58e88e2ffb6cb387715244 > > > > > Reviewed-on: https://chromium-review.googlesource.com/976944 > > > > > Reviewed-by: Siddhartha S <ssid@chromium.org> > > > > > Reviewed-by: agrieve <agrieve@chromium.org> > > > > > Commit-Queue: Siddhartha S <ssid@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#546425} > > > > > > > > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org > > > > > > > > Change-Id: Id033094871dfcf74248f631390f15f379d9cd3c7 > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: 819888 > > > > Reviewed-on: https://chromium-review.googlesource.com/983893 > > > > Reviewed-by: agrieve <agrieve@chromium.org> > > > > Commit-Queue: agrieve <agrieve@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#546478} > > > > > > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org > > > > > > Change-Id: I100f540c8d5bc9f59b9631ea207c7f290dc42e96 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 819888 > > > Reviewed-on: https://chromium-review.googlesource.com/985112 > > > Commit-Queue: Siddhartha S <ssid@chromium.org> > > > Reviewed-by: Siddhartha S <ssid@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#547196} > > > > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org > > > > Change-Id: Ifa59a5882b18c2634bcf96c2c1fc58b09d7f303f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 819888 > > Reviewed-on: https://chromium-review.googlesource.com/989153 > > Reviewed-by: Siddhartha S <ssid@chromium.org> > > Commit-Queue: Siddhartha S <ssid@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#547332} > > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,ctzsm@chromium.org > > Change-Id: I7750c70e52b55ccfbf1e2457a19fee4852575e59 > Bug: 819888 > Reviewed-on: https://chromium-review.googlesource.com/989192 > Commit-Queue: Siddhartha S <ssid@chromium.org> > Reviewed-by: Siddhartha S <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547361} TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,ctzsm@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 819888 Change-Id: I064a5bdae54fa1552eee14ee72d08f15cf081a63 Reviewed-on: https://chromium-review.googlesource.com/990092 Reviewed-by: Siddhartha S <ssid@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#547490}
- Loading branch information