Skip to content

Commit

Permalink
gpu: Clean up unused partial swap workaround
Browse files Browse the repository at this point in the history
With crrev.com/c/1830084 we removed the only workaround that was using
disable_non_empty_post_sub_buffers_for_onscreen_surfaces.

This CL cleans up related code.

Bug: 457511
Change-Id: Id2ea16b9ce91e5b59401e253519057c7f45796a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700562
Auto-Submit: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742990}
  • Loading branch information
DCastagna authored and Commit Bot committed Feb 20, 2020
1 parent 8b84245 commit c81dddd
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 13 deletions.
4 changes: 0 additions & 4 deletions components/viz/service/display/direct_renderer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,6 @@ void DirectRenderer::Initialize() {
if (context_provider) {
if (context_provider->ContextCapabilities().commit_overlay_planes)
allow_empty_swap_ = true;
if (context_provider->ContextCapabilities()
.disable_non_empty_post_sub_buffers) {
use_partial_swap_ = false;
}
#if DCHECK_IS_ON()
supports_occlusion_query_ =
context_provider->ContextCapabilities().occlusion_query;
Expand Down
3 changes: 0 additions & 3 deletions gpu/command_buffer/common/capabilities.h
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,6 @@ struct GPU_EXPORT Capabilities {
// details.
bool chromium_image_rgb_emulation = false;

// When true, non-empty post sub buffer calls are unsupported.
bool disable_non_empty_post_sub_buffers = false;

bool disable_2d_canvas_copy_on_write = false;

bool texture_npot = false;
Expand Down
4 changes: 0 additions & 4 deletions gpu/command_buffer/service/gles2_cmd_decoder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4335,10 +4335,6 @@ Capabilities GLES2DecoderImpl::GetCapabilities() {
group_->gpu_feature_info()
.status_values[GPU_FEATURE_TYPE_GPU_RASTERIZATION] ==
kGpuFeatureStatusEnabled;
if (workarounds().disable_non_empty_post_sub_buffers_for_onscreen_surfaces &&
!surface_->IsOffscreen()) {
caps.disable_non_empty_post_sub_buffers = true;
}
if (workarounds().broken_egl_image_ref_counting &&
group_->gpu_preferences().enable_threaded_texture_mailboxes) {
caps.disable_2d_canvas_copy_on_write = true;
Expand Down
1 change: 0 additions & 1 deletion gpu/config/gpu_workaround_list.txt
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ disable_gl_rgb_format
disable_half_float_for_gmb
disable_larger_than_screen_overlays
disable_multisampling_color_mask_usage
disable_non_empty_post_sub_buffers_for_onscreen_surfaces
disable_nv12_dxgi_video
disable_nv12_dynamic_textures
disable_overlay_ca_layers
Expand Down
1 change: 0 additions & 1 deletion gpu/ipc/common/gpu_command_buffer_traits_multi.h
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ IPC_STRUCT_TRAITS_BEGIN(gpu::Capabilities)
IPC_STRUCT_TRAITS_MEMBER(protected_video_swap_chain)
IPC_STRUCT_TRAITS_MEMBER(gpu_vsync)
IPC_STRUCT_TRAITS_MEMBER(shared_image_swap_chain)
IPC_STRUCT_TRAITS_MEMBER(disable_non_empty_post_sub_buffers)
IPC_STRUCT_TRAITS_MEMBER(avoid_stencil_buffers)
IPC_STRUCT_TRAITS_MEMBER(disable_2d_canvas_copy_on_write)
IPC_STRUCT_TRAITS_MEMBER(texture_npot)
Expand Down

0 comments on commit c81dddd

Please sign in to comment.