forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[DevTools] Consolidate overlay-related functionality in Overlay domain
This turns InspectorOverlay into InspectorOverlayAgent with respective lifetime and domain: - rendering domain merges into overlay; - Page.configureOverlay moves to overlay; - highlighting and inspect mode move from DOM to overlay. BUG=none TBR=skyostil@chromium.org Review-Url: https://codereview.chromium.org/2819183002 Cr-Original-Original-Commit-Position: refs/heads/master@{#465422} Committed: https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae58cff1c787bec Review-Url: https://codereview.chromium.org/2819183002 Cr-Original-Commit-Position: refs/heads/master@{#465812} Committed: https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a689648621fa29f14 Review-Url: https://codereview.chromium.org/2819183002 Cr-Commit-Position: refs/heads/master@{#466489}
- Loading branch information
Showing
63 changed files
with
1,296 additions
and
1,353 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,22 @@ | ||
Test that if a profiler is working all the agents are disabled. | ||
|
||
--> SDK.targetManager.suspendAllTargets(); | ||
frontend: {"id":<number>,"method":"Page.configureOverlay","params":{"suspended":true}} | ||
frontend: {"id":<number>,"method":"Target.setAutoAttach","params":{"autoAttach":true,"waitForDebuggerOnStart":false}} | ||
frontend: {"id":<number>,"method":"Debugger.disable"} | ||
frontend: {"id":<number>,"method":"Debugger.setAsyncCallStackDepth","params":{"maxDepth":0}} | ||
frontend: {"id":<number>,"method":"Page.configureOverlay","params":{"suspended":true}} | ||
frontend: {"id":<number>,"method":"Overlay.setPausedInDebuggerMessage"} | ||
frontend: {"id":<number>,"method":"DOM.disable"} | ||
frontend: {"id":<number>,"method":"CSS.disable"} | ||
frontend: {"id":<number>,"method":"Overlay.setSuspended","params":{"suspended":true}} | ||
|
||
--> SDK.targetManager.resumeAllTargets(); | ||
frontend: {"id":<number>,"method":"Page.configureOverlay","params":{"suspended":false}} | ||
frontend: {"id":<number>,"method":"Target.setAutoAttach","params":{"autoAttach":true,"waitForDebuggerOnStart":true}} | ||
frontend: {"id":<number>,"method":"Debugger.enable"} | ||
frontend: {"id":<number>,"method":"Debugger.setPauseOnExceptions","params":{"state":"none"}} | ||
frontend: {"id":<number>,"method":"Debugger.setAsyncCallStackDepth","params":{"maxDepth":8}} | ||
frontend: {"id":<number>,"method":"DOM.enable"} | ||
frontend: {"id":<number>,"method":"CSS.enable"} | ||
frontend: {"id":<number>,"method":"Overlay.setSuspended","params":{"suspended":false}} | ||
|
||
--> done | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.