forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix wrong backface visibility of composited layer under 3d transforms
In blink: - Change the condition in PaintPropertyTreeBuilder for inheriting parent backface visibility. Now a transform node inherits parent backface visibility if there is the parent doesn't preserve 3d and the current LayoutObject doesn't have 3d transform properties. This is based on dbaron@'s crrev.com/c/4917284. - Let TransformPaintPropertyNode::DelegatesToParentForBackface() reflect the backface visibility inheritance status, instead of the original State::delegates_to_parent_for_backface flag which is for scroll translation node only. In cc: - draw_property_utils functions related to backface visibility are changed to support TransformNode::delegates_to_parent_for_backface set on multiple levels of transform nodes. The blink changes are behind feature BackfaceVisibilityNewInheritance (enabled by default). When the feature is not enabled, the cc change has no effect because TransformNode::delegates_to_parent_for_backface won't be set on both a parent node and a child node. Bug: 954591 Change-Id: I39e8e46ebd053430368d3e6214a970dfce0c4940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4935628 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1211704}
- Loading branch information
1 parent
eb0d557
commit cb0abd4
Showing
16 changed files
with
185 additions
and
129 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 0 additions & 2 deletions
2
...y/blink/web_tests/external/wpt/css/css-transforms/backface-visibility-hidden-005.html.ini
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.