Skip to content

Commit

Permalink
Reassign all of earthdok's TODOs and remove from OWNERS.
Browse files Browse the repository at this point in the history
TBR=jln@chromium.org,thakis@chromium.org

Review URL: https://codereview.chromium.org/1646813004

Cr-Commit-Position: refs/heads/master@{#372260}
  • Loading branch information
leizleiz authored and Commit bot committed Jan 29, 2016
1 parent ab81d6c commit cee6906
Show file tree
Hide file tree
Showing 10 changed files with 13 additions and 14 deletions.
2 changes: 1 addition & 1 deletion build/common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -4388,7 +4388,7 @@
['_toolset=="target"', {
'cflags': [
'-fsanitize=address',
# TODO(earthdok): Re-enable. http://crbug.com/427202
# TODO(eugenis): Re-enable. http://crbug.com/427202
#'-fsanitize-blacklist=<(asan_blacklist)',
],
'ldflags': [
Expand Down
1 change: 0 additions & 1 deletion build/sanitizers/OWNERS
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
glider@chromium.org
earthdok@chromium.org
eugenis@chromium.org
per-file tsan_suppressions.cc=*
per-file lsan_suppressions.cc=*
2 changes: 1 addition & 1 deletion build/sanitizers/lsan_suppressions.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ char kLSanDefaultSuppressions[] =
// Leaks in Nvidia's libGL.
"leak:libGL.so\n"

// TODO(earthdok): revisit NSS suppressions after the switch to BoringSSL
// TODO(eugenis): revisit NSS suppressions after the switch to BoringSSL
// NSS leaks in CertDatabaseNSSTest tests. http://crbug.com/51988
"leak:net::NSSCertDatabase::ImportFromPKCS12\n"
"leak:net::NSSCertDatabase::ListCerts\n"
Expand Down
4 changes: 2 additions & 2 deletions content/zygote/zygote_linux.cc
Original file line number Diff line number Diff line change
Expand Up @@ -237,14 +237,14 @@ bool Zygote::HandleRequestFromBrowser(int fd) {

if (len == 0 || (len == -1 && errno == ECONNRESET)) {
// EOF from the browser. We should die.
// TODO(earthdok): call __sanititizer_cov_dump() here to obtain code
// TODO(eugenis): call __sanititizer_cov_dump() here to obtain code
// coverage for the Zygote. Currently it's not possible because of
// confusion over who is responsible for closing the file descriptor.
for (int fd : extra_fds_) {
PCHECK(0 == IGNORE_EINTR(close(fd)));
}
#if !defined(SANITIZER_COVERAGE)
// TODO(earthdok): add watchdog thread before using this in builds not
// TODO(eugenis): add watchdog thread before using this in builds not
// using sanitizer coverage.
CHECK(extra_children_.empty());
#endif
Expand Down
2 changes: 1 addition & 1 deletion printing/backend/print_backend_cups.cc
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ int PrintBackendCUPS::GetDests(cups_dest_t** dests) {
// than suppress. See http://crbug.com/176888#c7
// In theory any CUPS function can trigger this leak, but in
// PrintBackendCUPS, this is the most likely spot.
// TODO(earthdok): remove this once the leak is fixed.
// TODO(eugenis): remove this once the leak is fixed.
ANNOTATE_SCOPED_MEMORY_LEAK;
return cupsGetDests(dests);
} else {
Expand Down
6 changes: 3 additions & 3 deletions third_party/instrumented_libraries/instrumented_libraries.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@
{
'package_name': 'nss',
'dependencies=': [
# TODO(earthdok): get rid of this dependency
# TODO(eugenis): get rid of this dependency
'<(_sanitizer_type)-libnspr4',
],
'patch': 'patches/nss.diff',
Expand Down Expand Up @@ -630,7 +630,7 @@
'--disable-static',
# Without this flag there's a linking step that doesn't honor LDFLAGS
# and fails.
# TODO(earthdok): find a better fix.
# TODO(eugenis): find a better fix.
'--disable-gudev'
],
'pre_build': 'scripts/pre-build/udev.sh',
Expand Down Expand Up @@ -726,7 +726,7 @@
'--enable-gtk-doc',
# --enable-introspection introduces a build step that attempts to run
# a just-built binary and crashes. Vala requires introspection.
# TODO(earthdok): find a better fix.
# TODO(eugenis): find a better fix.
'--disable-introspection',
'--disable-vala',
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def download_build_install(self):
self.shell_call('rm -rf %s' % self._working_dir)

def fix_rpaths(self, directory):
# TODO(earthdok): reimplement fix_rpaths.sh in Python.
# TODO(eugenis): reimplement fix_rpaths.sh in Python.
script = real_path('scripts/fix_rpaths.sh')
self.shell_call("%s %s" % (script, directory))

Expand Down
4 changes: 2 additions & 2 deletions third_party/instrumented_libraries/scripts/fix_rpaths.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ function fix_rpath {
if [ -w "$1" ]
then
# Only attempt to fix RPATH if the entry actually exists.
# FIXME(earthdok): find out why zlib1g on Precise doesn't get RPATH set.
# FIXME(eugenis): find out why zlib1g on Precise doesn't get RPATH set.
if chrpath -l $1
then
echo "fix_rpaths.sh: fixing $1"
chrpath -r $(chrpath $1 | cut -d " " -f 2 | sed s/XORIGIN/\$ORIGIN/g \
| sed s/RPATH=//g) $1
fi
else
# FIXME(earthdok): libcups2 DSOs are created non-writable, causing this
# FIXME(eugenis): libcups2 DSOs are created non-writable, causing this
# script to fail. As a temporary measure, ignore non-writable files.
echo "fix_rpaths.sh: skipping non-writable file $1"
fi
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ then
sudo goobuntu-config set include_deb_src true
fi

# TODO(earthdok): find a way to pull the list from the build config.
# TODO(eugenis): find a way to pull the list from the build config.
common_packages="\
atk1.0 \
dee \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
{
'action_name': '<(_package_name)',
'inputs': [
# TODO(earthdok): reintroduce some sort of dependency
# TODO(eugenis): reintroduce some sort of dependency
# See http://crbug.com/343515
#'download_build_install.py',
],
Expand Down

0 comments on commit cee6906

Please sign in to comment.