forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove the native view host when CustomTab is closed.
Bug: b/169014289 Test: covered by unittest Change-Id: I769addac4e172eb16d5c363c8edca96c1877a346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637415 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#846018}
- Loading branch information
Showing
3 changed files
with
58 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
// Copyright 2021 The Chromium Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
#include "components/arc/intent_helper/custom_tab.h" | ||
|
||
#include <memory> | ||
|
||
#include "ui/aura/test/aura_test_base.h" | ||
#include "ui/views/test/test_views_delegate.h" | ||
#include "ui/views/widget/widget.h" | ||
|
||
namespace arc { | ||
|
||
using CustomTabTest = aura::test::AuraTestBase; | ||
|
||
// Make sure resizing the widget after closing custom tab will not crash. | ||
// b/169014289 | ||
TEST_F(CustomTabTest, ResizeAfterClose) { | ||
views::TestViewsDelegate views_delegate; | ||
|
||
views::Widget toplevel_widget; | ||
{ | ||
views::Widget::InitParams params(views::Widget::InitParams::TYPE_WINDOW); | ||
params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET; | ||
params.activatable = views::Widget::InitParams::ACTIVATABLE_YES; | ||
params.bounds = gfx::Rect(0, 0, 200, 200); | ||
params.parent = root_window(); | ||
toplevel_widget.Init(std::move(params)); | ||
} | ||
auto custom_tab = | ||
std::make_unique<CustomTab>(toplevel_widget.GetNativeWindow()); | ||
|
||
views::Widget embedded_widget; | ||
{ | ||
views::Widget::InitParams params(views::Widget::InitParams::TYPE_CONTROL); | ||
params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET; | ||
params.context = root_window(); | ||
embedded_widget.Init(std::move(params)); | ||
embedded_widget.Show(); | ||
} | ||
custom_tab->Attach(embedded_widget.GetNativeWindow()); | ||
toplevel_widget.Show(); | ||
|
||
custom_tab.reset(); | ||
// Resize to force re-layout child views to make sure that deleting the custom | ||
// tab removes the native view host inside upon deletion. | ||
toplevel_widget.SetSize(gfx::Size(250, 250)); | ||
} | ||
|
||
} // namespace arc |