forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
AW: ensure we respect user opt-out for SafeBrowsing
This separates Safe Browsing enabling into 3 requirements: 1. The user must opt into the feature 2. The app can enable/disable via WebSettings#setSafeBrowsingEnabled 3. The app can enable via manifest flag This adds tests to ensure that (1) has the highest priority. We already have tests to ensure that (2) has higher priority than (3). The CLI switch is treated equivalently to the manifest flag (same behavior as before). This also renames AwContentsStatics#{get,set}SafeBrowsingEnabled -> {get,set}SafeBrowsingEnabledByManifest. This is to clarify what this function actually does. The old method can be removed once downstream code no longer uses it. Bug: 731927 Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest#testSafeBrowsingUserOptOutOverrides* Change-Id: Id1d1a41f503b259addda14b027df0b3c18325b9c Reviewed-on: https://chromium-review.googlesource.com/572431 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Selim Gurun <sgurun@chromium.org> Cr-Commit-Position: refs/heads/master@{#487643}
- Loading branch information
1 parent
7bbc881
commit cfbec4b
Showing
7 changed files
with
78 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters