Skip to content

Commit

Permalink
Migrate libjingle to WebRTC build targets.
Browse files Browse the repository at this point in the history
This is a large improvement from the previous duplicated lists of
source files in WebRTC. This moves over to using the GYP/GN targets
in third_party/webrtc instead, which has become possible after landing
https://codereview.webrtc.org/1924663003/ and
https://codereview.webrtc.org/2037983002/.

BUG=webrtc:4256
TESTED=Local builds passing for Linux and Android.

Review-Url: https://codereview.chromium.org/2022833002
Cr-Commit-Position: refs/heads/master@{#408931}
  • Loading branch information
kjellander authored and Commit bot committed Aug 1, 2016
1 parent 6bc53f0 commit d0e9a07
Show file tree
Hide file tree
Showing 13 changed files with 97 additions and 674 deletions.
1 change: 1 addition & 0 deletions content/browser/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ source_set("browser") {
"//third_party/libjingle:libjingle_webrtc",
"//third_party/webrtc",
"//third_party/webrtc/base:rtc_base",
"//third_party/webrtc/media:rtc_media",
"//third_party/webrtc/modules/desktop_capture:primitives",
]
if (is_linux || is_mac || is_win) {
Expand Down
6 changes: 5 additions & 1 deletion content/renderer/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -172,13 +172,17 @@ target(link_target_type, "renderer") {
deps += [
"//crypto",
"//third_party/libjingle:libjingle_webrtc",
"//third_party/libjingle:libstunprober",
"//third_party/libvpx",
"//third_party/webrtc/api:libjingle_peerconnection",
"//third_party/webrtc/base:rtc_base",
"//third_party/webrtc/common_video",
"//third_party/webrtc/media:rtc_media",
"//third_party/webrtc/modules/audio_device",
"//third_party/webrtc/modules/audio_processing",
"//third_party/webrtc/modules/video_coding:webrtc_h264",
"//third_party/webrtc/p2p:libstunprober",
"//third_party/webrtc/p2p:rtc_p2p",
"//third_party/webrtc/pc:rtc_pc",
"//third_party/webrtc/system_wrappers",
]
if (rtc_use_h264) {
Expand Down
4 changes: 4 additions & 0 deletions content/test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,9 @@ static_library("test_support") {

deps += [
"//third_party/libjingle:libjingle_webrtc",
"//third_party/webrtc/api:libjingle_peerconnection",
"//third_party/webrtc/base:rtc_base",
"//third_party/webrtc/media:rtc_media",
"//third_party/webrtc/modules/video_capture",
]
}
Expand Down Expand Up @@ -728,7 +730,9 @@ test("content_unittests") {
deps += [
"//media/blink",
"//third_party/libjingle:libjingle_webrtc",
"//third_party/webrtc/api:libjingle_peerconnection",
"//third_party/webrtc/base:rtc_base",
"//third_party/webrtc/media:rtc_media",
"//third_party/webrtc/modules/desktop_capture:primitives",
"//third_party/webrtc/modules/video_capture",
"//ui/shell_dialogs:shell_dialogs",
Expand Down
4 changes: 4 additions & 0 deletions jingle/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ if (enable_webrtc || !is_android) {

public_deps = [
"//third_party/libjingle",
"//third_party/webrtc/libjingle/xmllite",
"//third_party/webrtc/libjingle/xmpp",
]
deps = [
":jingle_glue",
Expand Down Expand Up @@ -163,6 +165,8 @@ if (enable_webrtc || !is_android) {

public_deps = [
"//third_party/libjingle",
"//third_party/webrtc/libjingle/xmllite",
"//third_party/webrtc/libjingle/xmpp",
]
deps = [
":jingle_glue",
Expand Down
6 changes: 6 additions & 0 deletions jingle/jingle.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,15 @@
'../net/net.gyp:net',
'../third_party/expat/expat.gyp:expat',
'../third_party/libjingle/libjingle.gyp:libjingle',
'../third_party/webrtc/libjingle/xmllite/xmllite.gyp:rtc_xmllite',
'../third_party/webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp',
'../url/url.gyp:url_lib',
'jingle_glue',
],
'export_dependent_settings': [
'../third_party/libjingle/libjingle.gyp:libjingle',
'../third_party/webrtc/libjingle/xmllite/xmllite.gyp:rtc_xmllite',
'../third_party/webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp',
],
},
# GN version: //jingle:notifier_test_util
Expand Down Expand Up @@ -175,6 +179,8 @@
'../testing/gmock.gyp:gmock',
'../testing/gtest.gyp:gtest',
'../third_party/libjingle/libjingle.gyp:libjingle',
'../third_party/webrtc/libjingle/xmllite/xmllite.gyp:rtc_xmllite',
'../third_party/webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp',
],
},
],
Expand Down
14 changes: 12 additions & 2 deletions remoting/host/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,8 @@ static_library("test_support") {
if (enable_webrtc) {
public_deps += [
"//third_party/libjingle:libjingle_webrtc",
"//third_party/webrtc/libjingle/xmllite",
"//third_party/webrtc/libjingle/xmpp",
"//third_party/webrtc/modules/desktop_capture",
]
}
Expand Down Expand Up @@ -767,7 +769,11 @@ if (enable_remoting_host && !is_android) {
}

if (enable_webrtc) {
deps += [ "//third_party/libjingle:libjingle_webrtc" ]
deps += [
"//third_party/libjingle:libjingle_webrtc",
"//third_party/webrtc/libjingle/xmllite",
"//third_party/webrtc/libjingle/xmpp",
]
}
}

Expand Down Expand Up @@ -893,7 +899,11 @@ if (enable_me2me_host) {
}

if (enable_webrtc) {
deps += [ "//third_party/libjingle:libjingle_webrtc" ]
deps += [
"//third_party/libjingle:libjingle_webrtc",
"//third_party/webrtc/libjingle/xmllite",
"//third_party/webrtc/libjingle/xmpp",
]
}

if (is_desktop_linux) {
Expand Down
6 changes: 5 additions & 1 deletion remoting/protocol/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ static_library("protocol") {
"//remoting")

if (enable_webrtc) {
deps += [ "//third_party/libjingle:libjingle_webrtc" ]
deps += [
"//third_party/libjingle:libjingle_webrtc",
"//third_party/webrtc/libjingle/xmllite",
"//third_party/webrtc/libjingle/xmpp",
]
} else {
sources -= [
"webrtc_connection_to_client.cc",
Expand Down
6 changes: 6 additions & 0 deletions remoting/remoting.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -239,11 +239,15 @@
'../third_party/boringssl/boringssl.gyp:boringssl',
'../third_party/expat/expat.gyp:expat',
'../third_party/libjingle/libjingle.gyp:libjingle',
'../third_party/webrtc/libjingle/xmllite/xmllite.gyp:rtc_xmllite',
'../third_party/webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp',
'../third_party/libyuv/libyuv.gyp:libyuv',
'remoting_base',
],
'export_dependent_settings': [
'../third_party/libjingle/libjingle.gyp:libjingle',
'../third_party/webrtc/libjingle/xmllite/xmllite.gyp:rtc_xmllite',
'../third_party/webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp',
],
'sources': [
'<@(remoting_protocol_sources)',
Expand All @@ -254,6 +258,8 @@
['enable_webrtc == 1', {
'dependencies': [
'../third_party/libjingle/libjingle.gyp:libjingle_webrtc',
'../third_party/webrtc/libjingle/xmllite/xmllite.gyp:rtc_xmllite',
'../third_party/webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp',
],
}],
],
Expand Down
2 changes: 2 additions & 0 deletions remoting/signaling/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ static_library("signaling") {
public_deps = [
"//remoting/proto",
"//third_party/libjingle",
"//third_party/webrtc/libjingle/xmllite",
"//third_party/webrtc/libjingle/xmpp",
]

deps = [
Expand Down
Loading

0 comments on commit d0e9a07

Please sign in to comment.