Skip to content

Commit

Permalink
[infra/config] make win7-rel optional in CQ
Browse files Browse the repository at this point in the history
Now I migrated tests ran on win7-rel to win10_chromium_x64_rel_ng.
And win7-rel does not give us much better additional coverage.
http://shortn/_ZxVQj98HtK
When only win7-rel fails, it almost always only tells us that there
are test flakiness.

I will send PSA when landing this.

Bug: 987847
Change-Id: Ib9b912854e6b43e9985053e8dcb90a98abee65fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753376
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687155}
  • Loading branch information
Takuto Ikuta authored and Commit Bot committed Aug 15, 2019
1 parent ff3d0e1 commit d20af38
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
2 changes: 0 additions & 2 deletions docs/infra/cq_builders.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ These builders must pass before a CL may land.

* [win10_chromium_x64_rel_ng](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win10_chromium_x64_rel_ng) ([`commit-queue.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:commit-queue.cfg+chromium/try/win10_chromium_x64_rel_ng)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+win10_chromium_x64_rel_ng))

* [win7-rel](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7-rel) ([`commit-queue.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:commit-queue.cfg+chromium/try/win7-rel)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+win7-rel))

* [win_chromium_compile_dbg_ng](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win_chromium_compile_dbg_ng) ([`commit-queue.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:commit-queue.cfg+chromium/try/win_chromium_compile_dbg_ng)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+win_chromium_compile_dbg_ng))


Expand Down
3 changes: 0 additions & 3 deletions infra/config/commit-queue.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,6 @@ config_groups {
builders {
name: "chromium/try/win10_chromium_x64_rel_ng"
}
builders {
name: "chromium/try/win7-rel"
}
builders {
name: "chromium/try/win_chromium_compile_dbg_ng"
}
Expand Down

0 comments on commit d20af38

Please sign in to comment.