Remove //third_party/findbugs (unused)

Bug: 777511
Change-Id: I4cf8f627784038f1fb0ed32d8f25843bdbff3613
Reviewed-on: https://chromium-review.googlesource.com/916556
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536732}

DEPS

@@ -357,11 +357,6 @@ deps = {
   'src/third_party/ffmpeg':
     Var('chromium_git') + '/chromium/third_party/ffmpeg.git' + '@' + '58a80d15568fa98c07bd5e89ab8afcb018291c58',
 
-  'src/third_party/findbugs': {
-      'url': Var('chromium_git') + '/chromium/deps/findbugs.git' + '@' + '4275d9ac8610db6b1bc9a5e887f97e41b33fac67',
-      'condition': 'checkout_android',
-  },
-
   'src/third_party/flac':
     Var('chromium_git') + '/chromium/deps/flac.git' + '@' + '7d0f5b3a173ffe98db08057d1f52b7787569e0a6',
 

third_party/.gitignore

@@ -57,7 +57,6 @@
 /espresso/lib/
 /eyesfree/src
 /ffmpeg
-/findbugs
 /flac
 /flatbuffers/src
 /fontconfig/src

third_party/robolectric/BUILD.gn

@@ -57,8 +57,8 @@ java_library("robolectric_java") {
     ":robolectric_utils_java",
     ":shadows_core_java",
     "//third_party/bouncycastle:bouncycastle_java",
-    "//third_party/findbugs:jsr305_java",
     "//third_party/guava:guava_java",
+    "//third_party/jsr-305:jsr_305_javalib",
     "//third_party/junit:junit",
     "//third_party/xstream:xstream_java",
   ]
@@ -129,8 +129,8 @@ java_library("robolectric_annotations_java") {
   deps = [
     ":android-all-8.1.0-robolectric-r4402310_java",
     ":robolectric_shadowapi_java",
-    "//third_party/findbugs:jsr305_java",
     "//third_party/intellij:intellij_annotations_java",
+    "//third_party/jsr-305:jsr_305_javalib",
   ]
   java_files = [
     "robolectric/annotations/src/main/java/org/robolectric/annotation/AccessibilityChecks.java",
@@ -151,10 +151,10 @@ java_annotation_processor("robolectric_processor") {
   deps = [
     ":robolectric_annotations_java",
     "//build/android:sun_tools_java",
-    "//third_party/findbugs:jsr305_java",
     "//third_party/gson:gson_java",
     "//third_party/guava:guava_java",
     "//third_party/intellij:intellij_annotations_java",
+    "//third_party/jsr-305:jsr_305_javalib",
   ]
   provider_configurations = [ "local/processor/src/main/resources/META-INF/services/javax.annotation.processing.Processor" ]
   main_class = "org.robolectric.annotation.processing.RobolectricProcessor"
@@ -190,8 +190,8 @@ java_library("robolectric_resources_java") {
     ":android-all-8.1.0-robolectric-r4402310_java",
     ":robolectric_annotations_java",
     ":robolectric_utils_java",
-    "//third_party/findbugs:jsr305_java",
     "//third_party/guava:guava_java",
+    "//third_party/jsr-305:jsr_305_javalib",
   ]
   java_files = [
     "robolectric/resources/src/main/java/org/robolectric/RoboSettings.java",
@@ -282,8 +282,8 @@ java_library("robolectric_sandbox_java") {
     ":robolectric_annotations_java",
     ":robolectric_shadowapi_java",
     ":robolectric_utils_java",
-    "//third_party/findbugs:jsr305_java",
     "//third_party/guava:guava_java",
+    "//third_party/jsr-305:jsr_305_javalib",
     "//third_party/ow2_asm:asm_commons_java",
     "//third_party/ow2_asm:asm_java",
     "//third_party/ow2_asm:asm_tree_java",
@@ -327,7 +327,7 @@ java_library("robolectric_junit_java") {
     ":robolectric_annotations_java",
     ":robolectric_sandbox_java",
     ":robolectric_shadowapi_java",
-    "//third_party/findbugs:jsr305_java",
+    "//third_party/jsr-305:jsr_305_javalib",
     "//third_party/junit:junit",
   ]
 
@@ -337,7 +337,7 @@ java_library("robolectric_junit_java") {
 java_library("robolectric_shadowapi_java") {
   testonly = true
   deps = [
-    "//third_party/findbugs:jsr305_java",
+    "//third_party/jsr-305:jsr_305_javalib",
   ]
 
   java_files = [
@@ -677,7 +677,7 @@ java_library("shadows_core_java") {
     ":robolectric_shadowapi_java",
     ":robolectric_utils_java",
     "//third_party/accessibility_test_framework:accessibility_test_framework_java",
-    "//third_party/findbugs:jsr305_java",
+    "//third_party/jsr-305:jsr_305_javalib",
 
     # Note that gson is not a direct dependency for this library, but must be
     # in the classpath when the Robolectric annotation processor runs.

tools/android/eclipse/.classpath

@@ -241,7 +241,6 @@ to the classpath for downstream development. See "additional_entries" below.
     <classpathentry kind="lib" path="third_party/android_tools/sdk/extras/android/support/v7/appcompat/libs/android-support-v7-appcompat.jar" sourcepath="third_party/android_tools/sdk/sources"/>
     <classpathentry kind="lib" path="third_party/bouncycastle/lib/bcprov-jdk16-1.46.jar"/>
     <classpathentry kind="lib" path="third_party/byte_buddy/lib/byte-buddy-1.4.17.jar"/>
-    <classpathentry kind="lib" path="third_party/findbugs/lib/findbugs.jar"/>
     <classpathentry kind="lib" path="third_party/hamcrest/lib/hamcrest-library-1.3.jar"/>
     <classpathentry kind="lib" path="third_party/intellij/lib/annotations-12.0.jar"/>
     <classpathentry kind="lib" path="third_party/junit/src/lib/hamcrest-core-1.3.jar" sourcepath="third_party/junit/src/lib/hamcrest-core-1.3-sources.jar"/>