Skip to content

Commit

Permalink
Reland "Disable lazy serialization in network interfaces."
Browse files Browse the repository at this point in the history
This is a reland of e9bf5c8

The failing test was disabled in r621196.

Original change's description:
> Disable lazy serialization in network interfaces.
>
> Per discussion in https://chromium-review.googlesource.com/c/chromium/src/+/1374957, we don't see a
> performance gain from enabling them. Since this has a binary size cost, disable it.
>
> Bug: 803125
>
> Change-Id: I03090214fdb7ecba9e987065e62ca2a1d6dfd430
> Reviewed-on: https://chromium-review.googlesource.com/c/1391913
> Reviewed-by: Ken Rockot <rockot@google.com>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#620507}

Bug: 803125
Change-Id: I9c267ff429275f11406f2ab61eb52abbce62f15f
TBR: rockot@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1403185
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621215}
  • Loading branch information
John Abd-El-Malek authored and Commit Bot committed Jan 9, 2019
1 parent f65d67a commit d40f488
Showing 1 changed file with 1 addition and 22 deletions.
23 changes: 1 addition & 22 deletions services/network/public/mojom/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -48,22 +48,6 @@ mojom("mutable_network_traffic_annotation_interface") {
]
}

# UDP socket interface relies on mojo.common.mojom.ReadOnlyBuffer, which is
# mapped to base::span<const uint8_t>. ReadOnlyBufffer doesn't yet work with
# lazy serialization, so this needs to be in a separate target that doesn't have
# support_lazy_serialization = true.
mojom("udp_socket_interface") {
sources = [
"udp_socket.mojom",
]

public_deps = [
":mojom_ip_address",
":mutable_network_traffic_annotation_interface",
"//mojo/public/mojom/base:read_only_buffer",
]
}

# This target is split from "mojom" target as the lazy serialization may
# cause problems. See https://crbug.com/822732.
mojom("websocket_mojom") {
Expand All @@ -85,11 +69,6 @@ mojom("websocket_mojom") {
}

mojom("mojom") {
# URLLoader & URLLoaderFactory are used in-process in the browser when
# navigation uses URLLoader (NavigationMojoResponse) and in the renderer
# when Service Worker uses direct communication (S13nServiceWorker).
support_lazy_serialization = true

sources = [
"cookie_manager.mojom",
"cors.mojom",
Expand Down Expand Up @@ -118,6 +97,7 @@ mojom("mojom") {
"ssl_config.mojom",
"tcp_socket.mojom",
"tls_socket.mojom",
"udp_socket.mojom",
"url_loader.mojom",
"url_loader_factory.mojom",
]
Expand All @@ -126,7 +106,6 @@ mojom("mojom") {
":data_pipe_interfaces",
":mojom_ip_address",
":mutable_network_traffic_annotation_interface",
":udp_socket_interface",
":websocket_mojom",
"//components/content_settings/core/common:mojo_bindings",
"//mojo/public/mojom/base",
Expand Down

0 comments on commit d40f488

Please sign in to comment.