Skip to content

Commit

Permalink
Remove the temporary fix for crbug.com/908767
Browse files Browse the repository at this point in the history
Hindi strings with valid placeholders for these SIZE units have rolled
into chrome. The temporary fix can be removed therefore.

Bug: 923755
Change-Id: I1e5d3c5bcef9c0c381ace42651b69361c62d5a2b
Reviewed-on: https://chromium-review.googlesource.com/c/1424618
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624499}
  • Loading branch information
Noel Gordon authored and Commit Bot committed Jan 21, 2019
1 parent a109196 commit d7335aa
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions ui/file_manager/file_manager/common/js/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -216,23 +216,6 @@ util.bytesToString = function(bytes) {
'SIZE_TB',
'SIZE_PB'];

// TODO(crbug.com/909997): remove this if clause when translations are fixed.
if (window.postProcessedLoadTimeData_ !== true) {
const language = loadTimeData.getString('language');

// Replace invalid Hindi SIZE units translations, crbug.com/908767.
if (language === 'hi') {
loadTimeData.overrideValues({
'SIZE_KB': '$1 केबी',
'SIZE_MB': '$1 एमबी',
});
}

if (typeof language === 'string') {
window.postProcessedLoadTimeData_ = true;
}
}

// Minimum values for the units above.
var STEPS = [0,
Math.pow(2, 10),
Expand Down

0 comments on commit d7335aa

Please sign in to comment.