Skip to content

Commit

Permalink
Mash cleanup: Remove accelerator_controller.mojom and volume.mojom
Browse files Browse the repository at this point in the history
1. Prevent Chrome reaching directly into ash::AcceleratorController by
creating a pure virtual interface. The implementation is renamed
AcceleratorControllerImpl.

2. Move volume accelerator handling to ash. Convert VolumeController
interface into a single callback that Chrome provides. This callback
is run whenever the volume is changed via the keyboard.

Bug: 958225, 958131
Change-Id: Icc59608ad092eb9f53cda0637d0585ffdfa7f925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595507
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657774}
  • Loading branch information
Evan Stade authored and Commit Bot committed May 8, 2019
1 parent 459b1d6 commit d7748c5
Show file tree
Hide file tree
Showing 54 changed files with 398 additions and 497 deletions.
4 changes: 2 additions & 2 deletions ash/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ component("ash") {
"ash_service.h",

# TODO: move the following to source. Do NOT add new files here.
"accelerators/accelerator_controller.h",
"accessibility/accessibility_controller.h",
"accessibility/accessibility_delegate.h",
"accessibility/focus_ring_controller.h",
Expand Down Expand Up @@ -97,7 +96,8 @@ component("ash") {
"accelerators/accelerator_commands.h",
"accelerators/accelerator_confirmation_dialog.cc",
"accelerators/accelerator_confirmation_dialog.h",
"accelerators/accelerator_controller.cc",
"accelerators/accelerator_controller_impl.cc",
"accelerators/accelerator_controller_impl.h",
"accelerators/accelerator_ids.h",
"accelerators/accelerator_table.cc",
"accelerators/accelerator_table.h",
Expand Down
Loading

0 comments on commit d7748c5

Please sign in to comment.