Skip to content

Commit

Permalink
Files SWA: Remove cloud import code
Browse files Browse the repository at this point in the history
Removes cloud import related files and refactors tests as necessary.

Removes device_handler.js and its tests as they aren't used in the SWA.

Removes the navigation on device event using 'filePath' as that was only to support navigation to photo directories on cloud import action.

Bug: b/199451464, b/244124254
Tests: All existing tests pass
Change-Id: I4989a2a1643b809b9ae4c17164dbdbdf9e37a2c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3849642
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1044421}
  • Loading branch information
Alex Danilo authored and Chromium LUCI CQ committed Sep 8, 2022
1 parent 20903dd commit d79331f
Show file tree
Hide file tree
Showing 43 changed files with 24 additions and 11,732 deletions.
32 changes: 0 additions & 32 deletions chrome/browser/ash/file_manager/file_manager_jstest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,6 @@ IN_PROC_BROWSER_TEST_F(FileManagerJsTest, Crostini) {
RunTestURL("background/js/crostini_unittest.js");
}

IN_PROC_BROWSER_TEST_F(FileManagerJsTest, DeviceHandlerTest) {
RunTestURL("background/js/device_handler_unittest.js");
}

IN_PROC_BROWSER_TEST_F(FileManagerJsTest, DirectoryContentsTest) {
RunTestURL("foreground/js/directory_contents_unittest.js");
}
Expand All @@ -89,10 +85,6 @@ IN_PROC_BROWSER_TEST_F(FileManagerJsTest, DriveSyncHandlerTest) {
RunTestURL("background/js/drive_sync_handler_unittest.js");
}

IN_PROC_BROWSER_TEST_F(FileManagerJsTest, DuplicateFinderTest) {
RunTestURL("background/js/duplicate_finder_unittest.js");
}

IN_PROC_BROWSER_TEST_F(FileManagerJsTest, ExifParser) {
RunTestURL("foreground/js/metadata/exif_parser_unittest.js");
}
Expand Down Expand Up @@ -195,18 +187,6 @@ IN_PROC_BROWSER_TEST_F(CanvasFileManagerJsTest, ImageOrientation) {
RunTestURL("foreground/js/metadata/image_orientation_unittest.js");
}

IN_PROC_BROWSER_TEST_F(FileManagerJsTest, ImportControllerTest) {
RunTestURL("foreground/js/import_controller_unittest.js");
}

IN_PROC_BROWSER_TEST_F(FileManagerJsTest, ImporterCommonTest) {
RunTestURL("common/js/importer_common_unittest.js");
}

IN_PROC_BROWSER_TEST_F(FileManagerJsTest, ImportHistoryTest) {
RunTestURL("background/js/import_history_unittest.js");
}

IN_PROC_BROWSER_TEST_F(FileManagerJsTest, InstallLinuxPackageDialogTest) {
RunTestURL("foreground/js/ui/install_linux_package_dialog_unittest.js");
}
Expand All @@ -231,14 +211,6 @@ IN_PROC_BROWSER_TEST_F(FileManagerJsTest, LRUCacheTest) {
RunTestURL("common/js/lru_cache_unittest.js");
}

IN_PROC_BROWSER_TEST_F(FileManagerJsTest, MediaImportHandlerTest) {
RunTestURL("background/js/media_import_handler_unittest.js");
}

IN_PROC_BROWSER_TEST_F(FileManagerJsTest, MediaScannerTest) {
RunTestURL("background/js/media_scanner_unittest.js");
}

IN_PROC_BROWSER_TEST_F(FileManagerJsTest, Menu) {
RunTestURL("foreground/js/ui/menu_unittest.js");
}
Expand Down Expand Up @@ -307,10 +279,6 @@ IN_PROC_BROWSER_TEST_F(FileManagerJsTest, TaskController) {
RunTestURL("foreground/js/task_controller_unittest.js");
}

IN_PROC_BROWSER_TEST_F(FileManagerJsTest, TaskQueueTest) {
RunTestURL("background/js/task_queue_unittest.js");
}

IN_PROC_BROWSER_TEST_F(FileManagerJsTest, ThumbnailLoader) {
RunTestURL("foreground/js/thumbnail_loader_unittest.js");
}
Expand Down
Loading

0 comments on commit d79331f

Please sign in to comment.