Skip to content

Commit

Permalink
Disallow base\prefs from content. The reason is that content doesn't …
Browse files Browse the repository at this point in the history
…depend on it now, so it seems prudent to keep it this way so that other embedders of content aren't tied down to chrome's prefs system. Also, I worry that allowing content to use prefs would mean that it's a parallel way of configuring content from embedders, instead of just using the Content API.

Review URL: https://codereview.chromium.org/12262046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182773 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
jam@chromium.org committed Feb 15, 2013
1 parent 994df74 commit dae054d
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions content/DEPS
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
# Do NOT add chrome to the list below. We shouldn't be including files from
# src/chrome in src/content.
include_rules = [
"+cc",

"+crypto",

# The subdirectories in content/ will manually allow their own include
# directories in content/ so we disallow all of them.
"-content",
Expand All @@ -15,6 +11,13 @@ include_rules = [
"+content/shell", # for content_browsertests
"+content/test",

# content isn't tied to prefs so that other embedders are able to pick
# different ways of storing their preferences. Also, this is to avoid prefs
# being used as a parallel API to the Content API.
"-base/prefs",

"+cc",
"+crypto",
"+grit/content_resources.h",
"+grit/ui_resources.h",
"+grit/webkit_chromium_resources.h",
Expand Down

0 comments on commit dae054d

Please sign in to comment.