forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make remoting_me2me_host build properly for official Mac 64-bit builds.
remoting's symbol dumper was hard-coded to work on 32-bit x86 only. Similar to r184545 for Chrome, it is now updated to check the built product for what architectures are present. It will dump Breakpad symbols for 32-bit x86, x86_64, or both, as present. The symbol dumper is moved from an action in a distinct 'none'-type target to a postbuild in the correct target. There was no guarantee that the 'none' target would ever be built (and thus that symbols would be dumped), since nothing actually depended on this target. It is likely that whatever required symbols, if anything, was just building the 'All' target. This is not good practice. A postbuild on the correct target is the right way to dump these symbols. Review URL: https://chromiumcodereview.appspot.com/17003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206360 0039d316-1c4b-4281-b951-d872f2087c98
- Loading branch information
mark@chromium.org
committed
Jun 14, 2013
1 parent
35c4956
commit db45562
Showing
2 changed files
with
35 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters