Skip to content

Commit

Permalink
Include entries to blink_resources.
Browse files Browse the repository at this point in the history
We can't remove entries of webkit_chromium_resources just yet, because on
Blink side DumpRenderTree is still using it through Chromium :(

TBR=abarth@chromium.org, joth@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/20329005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214239 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
tfarina@chromium.org committed Jul 29, 2013
1 parent a2024ca commit db8dc3f
Show file tree
Hide file tree
Showing 12 changed files with 24 additions and 7 deletions.
1 change: 1 addition & 0 deletions android_webview/android_webview.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
'<(SHARED_INTERMEDIATE_DIR)/content/content_resources.pak',
'<(SHARED_INTERMEDIATE_DIR)/net/net_resources.pak',
'<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_resources_100_percent.pak',
'<(SHARED_INTERMEDIATE_DIR)/webkit/blink_resources.pak',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.pak',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_resources_100_percent.pak',
],
Expand Down
1 change: 1 addition & 0 deletions chrome/chrome_dll.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@
'<(SHARED_INTERMEDIATE_DIR)/content/browser/tracing/tracing_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/net/net_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_unscaled_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/blink_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.rc',
],
'include_dirs': [
Expand Down
1 change: 1 addition & 0 deletions chrome/chrome_repack_chrome.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
'pak_inputs': [
'<(SHARED_INTERMEDIATE_DIR)/content/content_resources.pak',
'<(SHARED_INTERMEDIATE_DIR)/content/browser/tracing/tracing_resources.pak',
'<(SHARED_INTERMEDIATE_DIR)/webkit/blink_resources.pak',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.pak',
],
}],
Expand Down
4 changes: 4 additions & 0 deletions chrome/chrome_tests.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@
'<(SHARED_INTERMEDIATE_DIR)/content/content_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/net/net_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_unscaled_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/blink_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.rc',

'browser/ui/views/accessibility/browser_views_accessibility_browsertest.cc',
Expand Down Expand Up @@ -1926,6 +1927,7 @@
'<(SHARED_INTERMEDIATE_DIR)/content/content_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/net/net_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_unscaled_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/blink_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.rc',
],
'include_dirs': [
Expand Down Expand Up @@ -2164,6 +2166,7 @@
'<(SHARED_INTERMEDIATE_DIR)/content/content_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/net/net_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_unscaled_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/blink_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.rc',
],
'include_dirs': [
Expand Down Expand Up @@ -2547,6 +2550,7 @@
'<(SHARED_INTERMEDIATE_DIR)/content/content_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/net/net_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_unscaled_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/blink_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.rc',
],
'include_dirs': [
Expand Down
1 change: 1 addition & 0 deletions chrome/chrome_tests_unit.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -2339,6 +2339,7 @@
'<(SHARED_INTERMEDIATE_DIR)/installer_util_strings/installer_util_strings.rc',
'<(SHARED_INTERMEDIATE_DIR)/net/net_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_unscaled_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/blink_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.rc',
],
'link_settings': {
Expand Down
1 change: 1 addition & 0 deletions chrome/test/gpu/test_support_gpu.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
'<(SHARED_INTERMEDIATE_DIR)/chrome_version/other_version.rc',
'<(SHARED_INTERMEDIATE_DIR)/content/content_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/net/net_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/blink_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.rc',
],
'conditions': [
Expand Down
1 change: 1 addition & 0 deletions content/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ include_rules = [
"-cc/base/scoped_ptr_vector.h",

"+crypto",
"+grit/blink_resources.h",
"+grit/content_resources.h",
"+grit/ui_resources.h",
"+grit/ui_strings.h",
Expand Down
1 change: 1 addition & 0 deletions content/browser/gpu/test_support_gpu.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
'sources': [
'<(SHARED_INTERMEDIATE_DIR)/content/content_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/net/net_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/blink_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.rc',
],
'conditions': [
Expand Down
1 change: 1 addition & 0 deletions content/content_shell.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,7 @@
'<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/webui_resources.pak',
'<(SHARED_INTERMEDIATE_DIR)/ui/ui_strings/ui_strings_en-US.pak',
'<(SHARED_INTERMEDIATE_DIR)/webkit/devtools_resources.pak',
'<(SHARED_INTERMEDIATE_DIR)/webkit/blink_resources.pak',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.pak',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_resources_100_percent.pak',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_strings_en-US.pak',
Expand Down
1 change: 1 addition & 0 deletions content/content_tests.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -894,6 +894,7 @@
# but that causes errors in other targets when
# resulting .res files get referenced multiple times.
'<(SHARED_INTERMEDIATE_DIR)/net/net_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/blink_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.rc',
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_strings_en-US.rc',
],
Expand Down
9 changes: 3 additions & 6 deletions tools/gritsettings/resource_ids
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,9 @@
"chrome_frame/resources/chrome_frame_resources.grd": {
"includes": [8000],
},
# WebKit.grd can be in two different places depending on whether we are
# in a chromium checkout or a webkit-only checkout.
"third_party/WebKit/Source/WebKit/chromium/WebKit.grd": {
"includes": [8500],
},
"WebKit.grd": {
"includes": [8500],
},

"ui/base/strings/app_locale_settings.grd": {
"messages": [9000],
},
Expand Down Expand Up @@ -223,5 +217,8 @@
"components/component_strings.grd": {
"messages": [30000],
},
"third_party/WebKit/public/blink_resources.grd": {
"includes": [30500],
},
# Resource ids starting at 31000 are reserved for projects built on Chromium.
}
9 changes: 8 additions & 1 deletion webkit/webkit_resources.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,19 @@
'includes': [ '../build/grit_action.gypi' ],
},
{
'action_name': 'blink_chromium_resources',
'action_name': 'webkit_chromium_resources',
'variables': {
'grit_grd_file': '../third_party/WebKit/Source/WebKit/chromium/WebKit.grd',
},
'includes': [ '../build/grit_action.gypi' ],
},
{
'action_name': 'blink_chromium_resources',
'variables': {
'grit_grd_file': '../third_party/WebKit/public/blink_resources.grd',
},
'includes': [ '../build/grit_action.gypi' ],
},
],
'includes': [ '../build/grit_target.gypi' ],
'direct_dependent_settings': {
Expand Down

0 comments on commit db8dc3f

Please sign in to comment.